Client silent error

Summary:
- `LifecycleObserver::onIngressEOF()` should've provided a ref to which session read an EOF, so I added that, cc hanidamlaj
- On a secure connection with no txn served, bump kErrorClientSilent

Reviewed By: hanidamlaj

Differential Revision: D82587556

fbshipit-source-id: 53991cd0b86dad153696f44fbf64fc8d9a88faa6

Author: Jacob Steinebronn

proxygen/lib/http/coro/HTTPCoroSession.cpp

@@ -2508,7 +2508,7 @@ folly::coro::Task<void> HTTPUniplexTransportSession::readLoop() noexcept {
     }
     if (*rc == 0) { // peer closed the connection
       XLOG(DBG4) << "Read EOF sess=" << *this;
-      deliverLifecycleEvent(&LifecycleObserver::onIngressEOF);
+      deliverLifecycleEvent(&LifecycleObserver::onIngressEOF, *this);
       codec_->onIngressEOF();
       for (auto& [_, stream] : streams_) {
         stream->abortIngress(HTTPErrorCode::TRANSPORT_EOF);

proxygen/lib/http/coro/HTTPCoroSession.h

@@ -127,7 +127,7 @@ class LifecycleObserver {
   }
   virtual void onIngressError(const HTTPCoroSession&, ProxygenError) {
   }
-  virtual void onIngressEOF() {
+  virtual void onIngressEOF(const HTTPCoroSession&) {
   }
   virtual void onRequestBegin(const HTTPCoroSession&) {
   }

proxygen/lib/http/coro/test/HTTPCoroSessionTests.h

@@ -176,7 +176,7 @@ class MockLifecycleObserver : public LifecycleObserver {
   // MOCK_METHOD(void, onConnectionError, (const HTTPCoroSession&));
   // MOCK_METHOD(void, onFullHandshakeCompletion, (const HTTPCoroSession&));
   MOCK_METHOD(void, onIngressError, (const HTTPCoroSession &, ProxygenError));
-  MOCK_METHOD(void, onIngressEOF, ());
+  MOCK_METHOD(void, onIngressEOF, (const HTTPCoroSession &));
   MOCK_METHOD(void,
               onRead,
               (const HTTPCoroSession &,

proxygen/lib/http/coro/test/HTTPDownstreamCoroSessionTests.cpp

@@ -1550,7 +1550,7 @@ TEST_P(HTTPDownstreamSessionTest, LifecycleObserver) {
   EXPECT_CALL(lifecycleCb, onActivateConnection(_));
   EXPECT_CALL(lifecycleCb, onIngressMessage(_, _));
   if (IS_H1()) {
-    EXPECT_CALL(lifecycleCb, onIngressEOF());
+    EXPECT_CALL(lifecycleCb, onIngressEOF(_));
   }
   EXPECT_CALL(lifecycleCb, onWrite(_, _)).Times(AtLeast(1));
   EXPECT_CALL(lifecycleCb, onRequestEnd(_, _));
@@ -1627,8 +1627,8 @@ TEST_P(HTTPDownstreamSessionTest, LifecycleObserverRemoveCallback) {
   EXPECT_CALL(otherLifecycleCb, onIngressMessage(_, _)).Times(0);
 
   if (IS_H1()) {
-    EXPECT_CALL(lifecycleCb, onIngressEOF());
-    EXPECT_CALL(otherLifecycleCb, onIngressEOF()).Times(0);
+    EXPECT_CALL(lifecycleCb, onIngressEOF(_));
+    EXPECT_CALL(otherLifecycleCb, onIngressEOF(_)).Times(0);
   }
   EXPECT_CALL(lifecycleCb, onWrite(_, _)).Times(AtLeast(1));
   EXPECT_CALL(otherLifecycleCb, onWrite(_, _)).Times(AnyNumber());
@@ -1713,8 +1713,8 @@ TEST_P(HTTPDownstreamSessionTest, MultiLifecycleObserver) {
   EXPECT_CALL(lifecycleCb, onIngressMessage(_, _));
   EXPECT_CALL(otherLifecycleCb, onIngressMessage(_, _));
   if (IS_H1()) {
-    EXPECT_CALL(lifecycleCb, onIngressEOF());
-    EXPECT_CALL(otherLifecycleCb, onIngressEOF());
+    EXPECT_CALL(lifecycleCb, onIngressEOF(_));
+    EXPECT_CALL(otherLifecycleCb, onIngressEOF(_));
   }
   EXPECT_CALL(lifecycleCb, onWrite(_, _)).Times(AtLeast(1));
   EXPECT_CALL(otherLifecycleCb, onWrite(_, _)).Times(AtLeast(1));