Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Pyre binaries using older Linux versions #873

Open
stroxler opened this issue Jun 3, 2024 · 0 comments
Open

Build Pyre binaries using older Linux versions #873

stroxler opened this issue Jun 3, 2024 · 0 comments

Comments

@stroxler
Copy link
Contributor

stroxler commented Jun 3, 2024

The released Linux Pyre binaries on PyPI are currently built from this codebase on machines that generally run very recent versions of Linux.

This has caused problems because the glibc Pyre's build picks up is very new, which can lead to failures like the one reported in #860 when users run against an older Linux.

A few fixes are possible, like trying to statically link some other C library, but the most standard solution is to just build in a container that has a reasonably old glibc so that the binary should "just work" for anyone running a not-ancient system.

To do this, we probably want to move our release builds to either github actions or CircleCI. In the process it would be a good idea to start running the full OCaml test suite in github CI (at the moment we only run it internally).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant