Split error message into multiple lines

Author: fangyi-zhou

conformance/third_party/conformance.exp

@@ -10045,8 +10045,8 @@
     {
       "code": -2,
       "column": 7,
-      "concise_description": "Inconsistent types for field `x` inherited from multiple base classes: `int` from `X2`, `str` from `Y2`",
-      "description": "Inconsistent types for field `x` inherited from multiple base classes: `int` from `X2`, `str` from `Y2`",
+      "concise_description": "Field `x` has inconsistent types inherited from multiple base classes",
+      "description": "Field `x` has inconsistent types inherited from multiple base classes\n  Inherited types include:\n    `int` from `X2`\n    `str` from `Y2`",
       "line": 65,
       "name": "inconsistent-inheritance",
       "stop_column": 11,

pyrefly/lib/alt/class/class_field.rs

@@ -11,7 +11,6 @@ use std::iter;
 use std::sync::Arc;
 
 use dupe::Dupe;
-use itertools::Itertools;
 use pyrefly_derive::TypeEq;
 use pyrefly_derive::VisitMut;
 use pyrefly_python::dunder;
@@ -1971,19 +1970,23 @@ impl<'a, Ans: LookupAnswer> AnswersSolver<'a, Ans> {
                 let types: Vec<Type> = class_and_types.iter().map(|(_, ty)| ty.clone()).collect();
                 let intersect = self.intersects(&types);
                 if matches!(intersect, Type::Never(_)) {
-                    let class_and_types_str = class_and_types
-                        .iter()
-                        .map(|(cls, ty)| {
-                            format!("`{}` from `{}`", self.for_display(ty.clone()), cls)
-                        })
-                        .join(", ");
-                    self.error(
-                        errors,
-                        cls.range(),
-                        ErrorInfo::Kind(ErrorKind::InconsistentInheritance),
+                    let mut error_msg = vec1![
                         format!(
-                            "Inconsistent types for field `{field_name}` inherited from multiple base classes: {class_and_types_str}",
+                            "Field `{field_name}` has inconsistent types inherited from multiple base classes"
                         ),
+                        "Inherited types include:".to_owned()
+                    ];
+                    for (cls, ty) in class_and_types.iter() {
+                        error_msg.push(format!(
+                            "  `{}` from `{}`",
+                            self.for_display(ty.clone()),
+                            cls
+                        ));
+                    }
+                    errors.add(
+                        cls.range(),
+                        ErrorInfo::Kind(ErrorKind::InconsistentInheritance),
+                        error_msg,
                     );
                 }
             }

pyrefly/lib/test/class_subtyping.rs

@@ -270,7 +270,7 @@ class Foo:
 class Bar:
     p: str
 
-class Both(Foo, Bar): # E: Inconsistent types for field `p` inherited from multiple base classes: `int` from `Foo`, `str` from `Bar`
+class Both(Foo, Bar): # E: Field `p` has inconsistent types inherited from multiple base classes
     ...
 "#,
 );