Fix CQS signal readability-const-return-type in xplat/js/react-native-github/packages (#53940)

generatedunixname89002005287564 · facebook-github-bot · commit 3fb6c12ec88a · 2025-09-29T08:16:45.000-07:00
Summary: Pull Request resolved: #53940 Reviewed By: javache Differential Revision: D83238455 fbshipit-source-id: ea3d3180f37151b3bba432d55324f2d854f29bc4
diff --git a/packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpInteractionTypes.cpp b/packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpInteractionTypes.cpp
@@ -51,7 +51,7 @@ const InteractionTypesMap& getInteractionTypes() {
   return INTERACTION_TYPES;
 }
 
-const std::string_view getInteractionTypeForEvent(std::string_view eventName) {
+std::string_view getInteractionTypeForEvent(std::string_view eventName) {
   const auto& interactionTypes = getInteractionTypes();
   auto it = interactionTypes.find(eventName);
   if (it != interactionTypes.end()) {
diff --git a/packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpInteractionTypes.h b/packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpInteractionTypes.h
@@ -17,6 +17,6 @@ using InteractionTypesMap =
 
 const InteractionTypesMap& getInteractionTypes();
 
-const std::string_view getInteractionTypeForEvent(std::string_view eventName);
+std::string_view getInteractionTypeForEvent(std::string_view eventName);
 
 } // namespace facebook::react
diff --git a/packages/react-native/ReactCommon/react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropComponentDescriptor.mm b/packages/react-native/ReactCommon/react/renderer/components/legacyviewmanagerinterop/LegacyViewManagerInteropComponentDescriptor.mm
@@ -104,7 +104,7 @@ static Class getViewManagerClass(const std::string &componentName, RCTBridge *br
   return nil;
 }
 
-static const std::shared_ptr<void> constructCoordinator(
+static std::shared_ptr<void> constructCoordinator(
     const std::shared_ptr<const ContextContainer> &contextContainer,
     const ComponentDescriptor::Flavor &flavor)
 {

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ const InteractionTypesMap& getInteractionTypes() {`
`51`	`51`	`return INTERACTION_TYPES;`
`52`	`52`	`}`
`53`	`53`
`54`		`-const std::string_view getInteractionTypeForEvent(std::string_view eventName) {`
	`54`	`+std::string_view getInteractionTypeForEvent(std::string_view eventName) {`
`55`	`55`	`const auto& interactionTypes = getInteractionTypes();`
`56`	`56`	`auto it = interactionTypes.find(eventName);`
`57`	`57`	`if (it != interactionTypes.end()) {`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ static Class getViewManagerClass(const std::string &componentName, RCTBridge *br`
`104`	`104`	`return nil;`
`105`	`105`	`}`
`106`	`106`
`107`		`-static const std::shared_ptr<void> constructCoordinator(`
	`107`	`+static std::shared_ptr<void> constructCoordinator(`
`108`	`108`	`const std::shared_ptr<const ContextContainer> &contextContainer,`
`109`	`109`	`const ComponentDescriptor::Flavor &flavor)`
`110`	`110`	`{`