Skip to content

Commit 50b1bec

Browse files
cortinicometa-codesync[bot]
authored andcommitted
RNGP - Move matchingFallbacks to be called inside maybeCreate("debugOptimized") (#54186)
Summary: Pull Request resolved: #54186 The `marchingFallback` directive is applied directly on the build type. However here is invoked inside the `externalNativeBuild` making it confusing, because in reality it has nothing to do with `externalNativeBuild`. So I'm moving it to the correct location (this has no effect on the build setup, is just to make the code easier to read). Changelog: [Internal] [Changed] - Reviewed By: cipolleschi Differential Revision: D84921628 fbshipit-source-id: 064336ad64a8e1de20b747276f6e5ca7ce7cb677
1 parent bc90648 commit 50b1bec

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

packages/gradle-plugin/react-native-gradle-plugin/src/main/kotlin/com/facebook/react/utils/AgpConfiguratorUtils.kt

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,8 @@ internal object AgpConfiguratorUtils {
4444
maybeCreate("debugOptimized").apply {
4545
manifestPlaceholders["usesCleartextTraffic"] = "true"
4646
initWith(debug)
47-
externalNativeBuild {
48-
cmake {
49-
arguments("-DCMAKE_BUILD_TYPE=Release")
50-
matchingFallbacks += listOf("release")
51-
}
52-
}
47+
matchingFallbacks += listOf("release")
48+
externalNativeBuild { cmake { arguments("-DCMAKE_BUILD_TYPE=Release") } }
5349
}
5450
}
5551
}

0 commit comments

Comments
 (0)