-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS][Old Arch][Codegen] - Codegen breaks pod install #46862
Comments
|
|
@gladiuscode Thanks for the issue but why should you
Even if Codegen gets executed, it is executed by your version of react-native and it is ensured to build properly. There are many people using react-native-webview in 0.75 on the Old Architecture and they don't have issues with that. In order to make sure that everything work, please try to clean your project:
Everything should work just fine. |
Hi @cipolleschi, thanks for your reply. I did break react-native-webview just to showcase that currently, running the old architecture, codegen breaks pods install anytime there is a library that has issues in the Spec file and that's our case. We've got a library that we can't patch ourself, it is compatibile with the new architecture, but has issues in the Spec file itself: so when we migrate from .73.x to .75.x it breaks the pods installation phase for the old architecture as well. |
Even in the old architecture, we generate Codegen. The reason is to minimize the differences between the two architectures to simplify the migration. What's the library that is breaking in your case? |
Ok, now I understand it a little bit better, thank you. In our case we are using a third party library that Cleafy provided us: this library supports both the old and new architecture and it has got an issue in the Spec file, it uses Tuples that aren't supported yet. If we stay on version 73.x, with the old architecture, no issues arise, we can run pod install and everything works. So taking what you said, there is a subtle issue for everyone who stays in the old architecture: anytime a library updates and makes changes that aren't supported yet by Codegen, it breaks both architecture, right? Given that everyone should move to the new one, not everyone can actually do so immediately, due to lock-ins, such our case, so what's the best course of action? Thank you for you time! |
I'm encountering the same issue while attempting to upgrade from React Native 0.73.7 to ^0.75.4. After following all the necessary steps for the upgrade, the process fails when trying to install the pods, resulting in the following error:
|
This error points to a misaligned version of Codegen for Is this coming from a library? Can you point out which one? I suggest to run |
@Mihai-github I have the same issue and i am stuck for weeks. Have you find a solution please? |
Please help me out, I have the same issue when running pod install. I have tried pod deintegrate, removing node_modules, clearing/invalidating caches, pod update whatever and i am still stuck here: [!] Invalid [Codegen] Analyzing /Users/martin/Documents/GitHub/PoleApp/package.json [Codegen] >>>>> Searching for codegen-enabled libraries in react-native.config.js from /Users/martin/Documents/GitHub/PoleApp/ios/Podfile:51-------------------------------------------
:path => config[:reactNativePath],------------------------------------------- |
@mpanac have you tried to bump the Google Mobile Ads SDK and React Native? If you can prepare a reproducer using this template with the Google Mobile Ads version you are using, I can try to investigate the issue more deeply. |
Hi! I face exactly the same problem, did you manage to solve it? Thanks in advance |
Description
Hi everyone! 👋
We are currently upgrading our application from version .73.8 to .75.4 and we've noticed something weird.
With the new version, if we run
pod install
, now Codegen gets executed differently than before.This would be fine if we actually enabled the new architecture, but we didn't and it breaks the pods install phase because some libraries are compatible with the new architecture but present issues in the Spec file that Codegen refers to.
I took the time to look into the changes between version .73.x and .75.x and I've noticed that this commit was included: Defragment Codegen in OSS between Old and New Architecture and it changes the following file: codegen.rb by removing the
new_arch_enabled
check in therun_codegen
function.I don't have a complete overview of how Codegen gets executed, by I think that we should revert this check for the sake of any project that can't migrate right away due to lock-ins: may them be by libraries or vendor code such as third party sdks.
Steps to reproduce
npx @react-native-community/cli@latest init RN75 --version 0.74 --pm npm
;npm install --save-dev react-native-webview
;react-native-webview
's Spec file by adding a Tuple that isn't supported yet; (Example down below)pod install
;Example:
React Native Version
0.74.0+
Affected Platforms
Build - MacOS
Output of
npx react-native info
Stacktrace or Logs
Reproducer
https://github.com/gladiuscode/codegen-breaks-pod-install-on-old-arch
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: