Fix RN-Tester JSC instacrashing #48418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: RNTester JSC Debug is currently insta-crashing on the 0.77 release branch due to: ``` 12-31 10:59:36.388 15165 15204 E ReactNativeJS: React Native version mismatch. 12-31 10:59:36.388 15165 15204 E ReactNativeJS: 12-31 10:59:36.388 15165 15204 E ReactNativeJS: JavaScript version: 0.77.0-rc.5 12-31 10:59:36.388 15165 15204 E ReactNativeJS: Native version: 1000.0.0-bb9d7ad9a 12-31 10:59:36.388 15165 15204 E ReactNativeJS: 12-31 10:59:36.388 15165 15204 E ReactNativeJS: Make sure that you have rebuilt the native code. If the problem persists try clearing the Watchman and packager caches with `watchman watch-del-all && npx react-native start --reset-cache`. ``` This is causing a `console.error` that is resulting in the crash as one of the frame in the stack doesn't have the line/column number information. Calling `.putDouble(string,double)` is forcing a conversion from `null` -> `double` which is result in the crash. This is happening only on CI because the `set-rn-version` step on GitHub Action is executed with `--dry-run` (as this is not a release run) so the version of React Native is set back to `1000.0.0-<SHA>`. Locally this doesn't happen because the React Native version is read from the local file which is never manipulated by the `set-rn-version`. Changelog: [ANDROID] [FIXED] - Fix JSC Debug instacrashing Differential Revision: D67735962
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67735962 |
|
This pull request has been merged in b10491a. |
|
This pull request was successfully merged by @cortinico in b10491a When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
RNTester JSC Debug is currently insta-crashing on the 0.77 release branch due to:
This is causing a
console.errorthat is resulting in the crash as one of the frame in the stack doesn't have the line/column number information. Calling.putDouble(string,double)is forcing a conversion fromnull->doublewhich is result in the crash.This is happening only on CI because the
set-rn-versionstep on GitHub Action is executed with--dry-run(as this is not a release run) so the version of React Native is set back to1000.0.0-<SHA>. Locally this doesn't happen because the React Native version is read from the local file which is never manipulated by theset-rn-version.Changelog:
[ANDROID] [FIXED] - Fix JSC Debug instacrashing
Differential Revision: D67735962