Make SurfaceManager const correct #48485
Closed
+7
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67820439 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
Summary: [Changelog] [Internal] - Make SurfaceManager const correct This marks methods which don't modify member props as `const` and others as non `const`. The current API signature is misleading as `const` methods do alter `mutable` members Differential Revision: D67820439
christophpurrer
force-pushed
the
export-D67820439
branch
from
ddbbde3 to
a2273d9
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
Summary: [Changelog] [Internal] - Make SurfaceManager const correct This marks methods which don't modify member props as `const` and others as non `const`. The current API signature is misleading as `const` methods do alter `mutable` members Differential Revision: D67820439
christophpurrer
force-pushed
the
export-D67820439
branch
from
a2273d9 to
38cd580
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67820439 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D67820439 |
christophpurrer
force-pushed
the
export-D67820439
branch
from
38cd580 to
e9cf7f7
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
Summary: [Changelog] [Internal] - Make SurfaceManager const correct This marks methods which don't modify member props as `const` and others as non `const`. The current API signature is misleading as `const` methods do alter `mutable` members Differential Revision: D67820439
|
This pull request was exported from Phabricator. Differential Revision: D67820439 |
christophpurrer
force-pushed
the
export-D67820439
branch
from
e9cf7f7 to
c86a5b6
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 4, 2025
Summary: [Changelog] [Internal] - Make SurfaceManager const correct This marks methods which don't modify member props as `const` and others as non `const`. The current API signature is misleading as `const` methods do alter `mutable` members Differential Revision: D67820439
|
This pull request was exported from Phabricator. Differential Revision: D67820439 |
|
@christophpurrer I don't know which problem you are solving, but I suspect this change is not correct. |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 6, 2025
Summary: [Changelog] [Internal] - Make SurfaceManager const correct This marks methods which don't modify member props as `const` and others as non `const`. The current API signature is misleading as `const` methods do alter `mutable` members Reviewed By: rshest Differential Revision: D67820439
christophpurrer
force-pushed
the
export-D67820439
branch
from
c86a5b6 to
8572ca1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67820439 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 6, 2025
Summary: [Changelog] [Internal] - Make SurfaceManager const correct This marks methods which don't modify member props as `const` and others as non `const`. The current API signature is misleading as `const` methods do alter `mutable` members Reviewed By: rshest Differential Revision: D67820439
christophpurrer
force-pushed
the
export-D67820439
branch
from
8572ca1 to
f58b490
Compare
Summary: [Changelog] [Internal] - Make SurfaceManager const correct This marks methods which don't modify member props as `const` and others as non `const`. The current API signature is misleading as `const` methods do alter `mutable` members Reviewed By: rshest Differential Revision: D67820439
|
This pull request was exported from Phabricator. Differential Revision: D67820439 |
christophpurrer
force-pushed
the
export-D67820439
branch
from
f58b490 to
6ff0bf3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67820439 |
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 6, 2025
Summary: [Changelog] [Internal] - Make SurfaceManager const correct This marks methods which don't modify member props as `const` and others as non `const`. The current API signature is misleading as `const` methods do alter `mutable` members Reviewed By: rshest Differential Revision: D67820439
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Jan 6, 2025
Summary: [Changelog] [Internal] - Make SurfaceManager const correct This marks methods which don't modify member props as `const` and others as non `const`. The current API signature is misleading as `const` methods do alter `mutable` members Reviewed By: rshest Differential Revision: D67820439
|
This pull request has been merged in c855251. |
|
This pull request was successfully merged by @christophpurrer in c855251 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
[Changelog] [Internal] - Make SurfaceManager const correct
This marks methods which don't modify member props as
constand others as nonconst.The current API signature is misleading as
constmethods do altermutablemembersDifferential Revision: D67820439