[compiler] _exp version of ValidateNoDerivedComputationsInEffects take precedence over stable version when enabled

jorge-cab · jorge-cab · commit a012a93ffd52 · 2025-11-10T16:39:42.000-08:00
Summary:
We should only run one version of the validation. I think it makes sense that if the exp version is enable it takes precedence over the stable one
diff --git a/compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Pipeline.ts b/compiler/packages/babel-plugin-react-compiler/src/Entrypoint/Pipeline.ts
@@ -272,12 +272,10 @@ function runWithEnvironment(
       validateNoSetStateInRender(hir).unwrap();
     }
 
-    if (env.config.validateNoDerivedComputationsInEffects) {
-      validateNoDerivedComputationsInEffects(hir);
-    }
-
     if (env.config.validateNoDerivedComputationsInEffects_exp) {
       env.logErrors(validateNoDerivedComputationsInEffects_exp(hir));
+    } else if (env.config.validateNoDerivedComputationsInEffects) {
+      validateNoDerivedComputationsInEffects(hir);
     }
 
     if (env.config.validateNoSetStateInEffects) {

Original file line number	Diff line number	Diff line change
`@@ -272,12 +272,10 @@ function runWithEnvironment(`
`272`	`272`	`validateNoSetStateInRender(hir).unwrap();`
`273`	`273`	`}`
`274`	`274`
`275`		`- if (env.config.validateNoDerivedComputationsInEffects) {`
`276`		`- validateNoDerivedComputationsInEffects(hir);`
`277`		`- }`
`278`		`-`
`279`	`275`	`if (env.config.validateNoDerivedComputationsInEffects_exp) {`
`280`	`276`	`env.logErrors(validateNoDerivedComputationsInEffects_exp(hir));`
	`277`	`+ } else if (env.config.validateNoDerivedComputationsInEffects) {`
	`278`	`+ validateNoDerivedComputationsInEffects(hir);`
`281`	`279`	`}`
`282`	`280`
`283`	`281`	`if (env.config.validateNoSetStateInEffects) {`