test: add coverage for zero-length style values #35027
Open
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures that empty string style values (e.g., { color: '' }) are skipped
during serialization, matching browser behavior and preventing hydration
mismatches.
Contributor
Author
|
cc @hoxyq , could you verify if the tests make sense and is useful to add. |
StuvanFIT
reviewed
Nov 11, 2025
StuvanFIT
left a comment
StuvanFIT
left a comment
There was a problem hiding this comment.
Great fix and nice job with passing the test cases!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new test case to verify that style properties with empty string values (e.g.,
{ color: '' })are correctly skipped during style serialization. This behavior prevents React from rendering invalid CSS likestyle="color:"and avoids potential hydration mismatches between server and client.https://github.com/facebook/react/blob/main/packages/react-dom-bindings/src/client/CSSPropertyOperations.js#L35
this line seems to be doing all the heavy lifting here, we already have
undefined&nulltest added and this PR adds theno zero-length styles, which completes the test coverage.cc @rickhanlonii @eps1lon