Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider fixing benchmark-linux in GitHub Action and re-enable the job #12615

Closed
jaykorean opened this issue May 3, 2024 · 12 comments
Closed

Comments

@jaykorean
Copy link
Contributor

Due to a Meta internal company-wide decision, we had to migrate from CircleCI to GitHub Actions. We were able to migrate all of the jobs except one, benchmark-linux. As of 05/02/2024, we deactivated all jobs from CircleCI.

Once we fix the job in GHA, we can consider re-enabling it.

Prior PRs for the migration for the reference: #12163, #12569, #12191

@jaykorean
Copy link
Contributor Author

cc @adamretter , @pdillinger , @ajkr

@jaykorean
Copy link
Contributor Author

AWS EC2 instance has been stopped (but not terminated). We can start the instance again when we start running the test again.

@adamretter
Copy link
Collaborator

@jaykorean Can you keep the instance running, so that we can connect to it, we can then investigate in the next few days if its possible to re-configure it for GitHub actions instead of CircleCI.

@jaykorean
Copy link
Contributor Author

jaykorean commented Jun 27, 2024

@adamretter Got it. Just started the instance again. I will update the Benchmark Status Update doc with the new hostname.

EDIT: Looks like I don't have the access to the google doc. Would you be able to grant me edit access? Just requested it.

@adamretter
Copy link
Collaborator

@jaykorean You should have access to the Google Doc now. I tried to SSH to the current hostname in there, but there is no access. Would you be able to update the hostname please?

@jaykorean
Copy link
Contributor Author

@adamretter Just updated the Google Doc with the new hostname. Please try it and let me know if there's any problem.

@adamretter
Copy link
Collaborator

@jaykorean Thanks, got it :-)

@jaykorean
Copy link
Contributor Author

@adamretter Just wanted to let you know that I received the heads up from Danny for the next steps. I will look into them later this month.

@adamretter
Copy link
Collaborator

@jaykorean Ace. Thanks. I think it should be pretty quick as we just need one thing enabled on your side and then we can continue finalising the config and setup.

@jaykorean
Copy link
Contributor Author

@adamretter You should be able to see the self-hosted runner added here - https://github.com/facebook/rocksdb/actions/runners?tab=self-hosted

@rhubner
Copy link
Contributor

rhubner commented Jul 25, 2024

Hello @jaykorean
Thank you for adding the self-hosted runner. Unfortunately we can't see the url you mentioned. I don't have enough permission and last time when we tried with @adamretter he also can't see them. But this shouldn't be a problem.

I can see you configured self hosted Linux machine in AWS, I can see it is connecting to GitHub. Unfortunately when I trigger job, it can't find benchmark-linux. I think the problem is that GitHub actions work on labels and not on self hosted runner names. Can you please add label benchmark-linux to the self hosted runner in GitHub console(the url you mentioned).

Thanks Radek.

@adamretter
Copy link
Collaborator

@rhubner I can see the URL now, and it shows the following:
Screenshot 2024-07-25 at 14 16 36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants