Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception for multiGet operation on corrupted database. #12766

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Throw exception for multiGet operation on corrupted database. #12766

wants to merge 3 commits into from

Conversation

rhubner
Copy link
Contributor

@rhubner rhubner commented Jun 13, 2024 •
edited
Loading

Fix #12741

@rhubner rhubner force-pushed the eb/multiget-corruption-bug branch 2 times, most recently from 798a72b to eec21a3 Compare June 19, 2024 11:57
@alanpaxton
Copy link
Contributor

@rhubner I found that the test class message on failure had sense the wrong way round. I pushed a slight improvement.
The PR is LGTM if you are happy with my change :-)

@rhubner
Copy link
Contributor Author

rhubner commented Jul 9, 2024

@rhubner I found that the test class message on failure had sense the wrong way round. I pushed a slight improvement. The PR is LGTM if you are happy with my change :-)

Thanks Alan. Looks good to me.

@rhubner rhubner marked this pull request as ready for review July 10, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RoksDB#multiGetAsList() silently ignores fetching values for keys if db file is corrupt.
3 participants
@rhubner @alanpaxton @facebook-github-bot