Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to iterate over non-default column family updates in WriteBatch using C API. #12790

Closed
konstantinvilin opened this issue Jun 21, 2024 · 1 comment

Comments

@konstantinvilin
Copy link
Contributor

WriteBatch Iterator exposed via C API does not allow column family specific operations: put_cf, delete_cf and merge_cf. This is required when the one needs to read changes for any non-default column family. Without that functionality it is impossible to iterate over changes in WAL that are relevant to custom column families.

Expected behavior

WriteBatch iterator in C API allows walking through non-default column family changes.

Actual behavior

WriteBatch iterator in C API only iterates over default column family changes.

Steps to reproduce the behavior

  1. Create WriteBatch and use put_cf, merge_cf or delete_cf to apply changes to a non-default column family.
  2. Use rocksdb_writebatch_iterate C API function to iterate over WriteBatch.
@konstantinvilin
Copy link
Contributor Author

I've submitted PR with a fix:
#12718

Could someone review it, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant