Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Stabilize ZSTD_createDDict_byReference #4283

Open
pdillinger opened this issue Feb 4, 2025 · 2 comments
Open

Request: Stabilize ZSTD_createDDict_byReference #4283

pdillinger opened this issue Feb 4, 2025 · 2 comments

Comments

@pdillinger
Copy link

This function (ZSTD_createDDict_byReference) is used by RocksDB, and long has been. It is essentially required for digested dictionary support so that we can manage raw bytes ourselves without memory duplication. It would be good (eventually) not to require ZSTD_STATIC_LINKING_ONLY for this feature. Some context in facebook/rocksdb#13362

@Cyan4973
Copy link
Contributor

Cyan4973 commented Feb 4, 2025

Context:
we are planning to release v1.5.7 soon.
Normally, such an updated version number doesn't include a change to the stable user API scope.
So either we do it nonetheless,
or we "properly" update to v1.6.0 instead,
but, in this case, several other topics currently registered for the v1.6.0 release would have to be considered too,
which would add workload, which would delay the release...

We have some tough choice ahead here.

@pdillinger
Copy link
Author

pdillinger commented Feb 4, 2025

This has been quietly outstanding for a while. Just requesting you get to it when you pretty easily can.

@terrelln terrelln mentioned this issue Mar 14, 2024
9 tasks
@Cyan4973 Cyan4973 added this to the v1.6.0 milestone Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants