auto cargo_env

[gilescope]

Could we just grep the source code for "CARGO_" and set cargo_env = true if we find it rather than specifying it explicitly in the fixups? I can't see there is much harm in a false positive and one could always set cargo_env = false in a fixup...

[Ralith]

Is there a meaningful drawback to populating supported cargo env vars unconditionally?

[gilescope]

Only one way to find out - fork reindeer and set it on always. It feels like it should be a config setting - maybe it already is but no one has written any config docs.

…

On Thu, 10 Apr 2025 at 19:11, Benjamin Saunders ***@***.***> wrote: Is there a meaningful drawback to populating supported cargo env vars unconditionally? — Reply to this email directly, view it on GitHub <#63 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGEJCBXXVNPSDFJIE6NI7T2Y2X57AVCNFSM6AAAAAB22YYF5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJUG4ZTOMBXGU> . You are receiving this because you authored the thread.Message ID: ***@***.***> *Ralith* left a comment (facebookincubator/reindeer#63) <#63 (comment)> Is there a meaningful drawback to populating supported cargo env vars unconditionally? — Reply to this email directly, view it on GitHub <#63 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGEJCBXXVNPSDFJIE6NI7T2Y2X57AVCNFSM6AAAAAB22YYF5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOOJUG4ZTOMBXGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[dtolnay]

I would accept a PR for a reindeer.toml setting that turns cargo_env on by default.

[thoughtpolice]

#76