{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":388946490,"defaultBranch":"main","name":"velox","ownerLogin":"facebookincubator","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2021-07-23T23:00:23.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/19538647?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1719958570.0","currentOid":""},"activityList":{"items":[{"before":"dda84502cbab7b53be6cf3eb140b403df7c0533c","after":"d6fcaadf6f267925bb349c2214896596c761269a","ref":"refs/heads/window_prefix_sort","pushedAt":"2024-07-04T06:50:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aditi-pandit","name":"Aditi Pandit","path":"/aditi-pandit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/87670623?s=80&v=4"},"commit":{"message":"Use PrefixSort in Window operator","shortMessageHtmlLink":"Use PrefixSort in Window operator"}},{"before":"4949fd28322663e7a7c4a6316f80c8eec2fb4dc9","after":"dda84502cbab7b53be6cf3eb140b403df7c0533c","ref":"refs/heads/window_prefix_sort","pushedAt":"2024-07-04T06:24:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aditi-pandit","name":"Aditi Pandit","path":"/aditi-pandit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/87670623?s=80&v=4"},"commit":{"message":"Use PrefixSort in Window operator","shortMessageHtmlLink":"Use PrefixSort in Window operator"}},{"before":"eb9a6f9c8de93dc82a8d5886fff04dacfa9e2c9b","after":"a8896188e67ebb6bcd3763987722e8d9fd8f9ab4","ref":"refs/heads/gh-pages","pushedAt":"2024-07-04T04:56:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Update build metrics","shortMessageHtmlLink":"Update build metrics"}},{"before":"1705bde412bd36586e16414b8fb3844f2b7c05f5","after":"26f001441e35c247abf3e8f588f2e70b72b951ec","ref":"refs/heads/main","pushedAt":"2024-07-03T22:48:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix tsan race in cache fuzzer test (#10391)\n\nSummary: Pull Request resolved: https://github.com/facebookincubator/velox/pull/10391\n\nTest Plan: Run through for 1hr under tsan mdoe\n\nReviewed By: kevinwilfong\n\nDifferential Revision: D59343096\n\nPulled By: xiaoxmeng\n\nfbshipit-source-id: 3e18020aa183dc411691c7191fd55814f8ec16f5","shortMessageHtmlLink":"Fix tsan race in cache fuzzer test (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2389301135\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10391\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10391/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10391\">#10391</a>)"}},{"before":"c5b9327d164744ec1797b5642f6981a6450da8e4","after":"eb9a6f9c8de93dc82a8d5886fff04dacfa9e2c9b","ref":"refs/heads/gh-pages","pushedAt":"2024-07-03T21:53:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Update documentation","shortMessageHtmlLink":"Update documentation"}},{"before":"02cbe7476cfdd006b22141c13abd0a19b1c88a48","after":"1705bde412bd36586e16414b8fb3844f2b7c05f5","ref":"refs/heads/main","pushedAt":"2024-07-03T21:53:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add exchange request count metrics (#10389)\n\nSummary:\nAdd to count exchange request counts.\n\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10389\n\nReviewed By: kevinwilfong\n\nDifferential Revision: D59335642\n\nPulled By: xiaoxmeng\n\nfbshipit-source-id: 8a715e681b0541e265a0656d1f083121e24df4b0","shortMessageHtmlLink":"Add exchange request count metrics (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2389131990\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10389\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10389/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10389\">#10389</a>)"}},{"before":"decd91eb50e6ef51cddb8e3251e3c3002111dd82","after":"02cbe7476cfdd006b22141c13abd0a19b1c88a48","ref":"refs/heads/main","pushedAt":"2024-07-03T20:22:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix NaN handling in comparison functions (#10165)\n\nSummary:\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10165\n\nThis change ensures that comparison functions treat all NaN bit\nrepresentations as equal and greater than infinity.\n\nSummary of changes:\nCurrently, numerical primitive types, including floating points, have\nan optimized SIMD implementation. However, this relies on low-level\ninstructions that follow IEEE floating point semantics, where NaN\ncompared to any other number, including itself, returns false. There\nis no trivial way to implement NaN checking and handling using SIMD,\nso for now, we are falling back to the regular non-SIMD version that\nemploys comparators supporting NaN handling in the intended way.\n\nAdditionally, this change currently handles this by adding a special\ncase in the ComparisonSimdFunction vector function instead of\nregistering the SimpleFunction for floating types. This is because\nregistering an additional/different function to handle floating types\nis causing a regression in an internal integration which is still under\ninvestigation.\n\nReviewed By: kgpai, kagamiori\n\nDifferential Revision: D58471982\n\nfbshipit-source-id: 1b092cc0feae2e7e56738031c5ac6d5a6f6f01db","shortMessageHtmlLink":"Fix NaN handling in comparison functions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2349310948\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10165\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10165/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10165\">#10165</a>)"}},{"before":"ac06de388ab0252784a0ea5ff6f101e0593ec603","after":"c5b9327d164744ec1797b5642f6981a6450da8e4","ref":"refs/heads/gh-pages","pushedAt":"2024-07-03T17:47:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Update documentation","shortMessageHtmlLink":"Update documentation"}},{"before":"0cb715ea35d4f49db2baef710abe000390ae96af","after":"decd91eb50e6ef51cddb8e3251e3c3002111dd82","ref":"refs/heads/main","pushedAt":"2024-07-03T17:46:26.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Call commitNull in SimpleFunctionAdapter on exceptions (#10377)\n\nSummary:\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10377\n\nThe way the VectorWriters work today, if its writing a variable length type and it is not committed\n(e.g. because an exception was thrown) when the next value is written it will start with the state of\nthe previous value rather than a clean slate.  This can result in e.g. strings starting with the contents\nthat were written for the previous string.\n\nSimpleFunctionAdapter tried to compensate for this by making a local copy of the top level\nVectorWriter and only copying back into the original if processing the current row succeeds.  This\ndoes nothing for nested writers (it also wasn't implemented for Strings).\n\nTo fix this, I've added an optional lambda to applyToSelectedNoThrow that gets invoked when an\nexception is caught.  We can use this to call commitNull on the writer which should reset the state\nof all writers (top level and nested).  Note that if we're catching exceptions and not throwing anything\nwe must be in a try so committing null is safe and reasonable to do.\n\nThis shouldn't impact the performance of the path without exceptions (I ran the ArrayWriterBenchmark to confirm this).  I also do not need to make this change in the fast path as\nthe fast path is only invoked if the output type is primitive and fixed width, and in this there is no\nstate other than the value in the Vector so failing to commit does not cause issues.\n\nThis combined with https://github.com/facebookincubator/velox/pull/10376 addresses the issue\nidentified in https://github.com/facebookincubator/velox/issues/10162\n\nReviewed By: mbasmanova\n\nDifferential Revision: D59292285\n\nfbshipit-source-id: 00c000626bb12451b7c95c24460eb62816532403","shortMessageHtmlLink":"Call commitNull in SimpleFunctionAdapter on exceptions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2387162603\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10377\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10377/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10377\">#10377</a>)"}},{"before":"659f07e7775161d99e5747a2d732e2cc00806fa7","after":"ac06de388ab0252784a0ea5ff6f101e0593ec603","ref":"refs/heads/gh-pages","pushedAt":"2024-07-03T17:43:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Update documentation","shortMessageHtmlLink":"Update documentation"}},{"before":"4e39b06c79660c86ebbab467ccfcd01a13857d93","after":"0cb715ea35d4f49db2baef710abe000390ae96af","ref":"refs/heads/main","pushedAt":"2024-07-03T17:42:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Reject duplicate sorting keys (#10040)\n\nSummary:\nA SQL query may specify duplicate sorting keys:\n\n```\nSELECT c1 FROM t ORDER BY c1, c1\n```\n\nSuch query fails in Gluten:\n\n```\nCaused by: java.lang.RuntimeException: Exception: VeloxRuntimeError\nError Source: RUNTIME\nError Code: INVALID_STATE\nReason: (1 vs. 2)\nRetriable: False\nExpression: input_->size() >= sortCompareFlags_.size()\nFunction: SortBuffer\nFile: /opt/gluten/gluten/ep/build-velox/build/velox_ep/velox/exec/SortBuffer.cpp\nLine: 36\n```\n\nHarden OrderByNode to reject duplicate sorting keys. The query planner should ensure the sorting keys are unique.\n\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10040\n\nReviewed By: kevinwilfong\n\nDifferential Revision: D59122341\n\nPulled By: bikramSingh91\n\nfbshipit-source-id: b2bab9a0d64c7a76908d48ca4503a7377aeff7b8","shortMessageHtmlLink":"Reject duplicate sorting keys (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2332729795\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10040\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10040/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10040\">#10040</a>)"}},{"before":"4fbf1553f40157cf3f5edf6a70646440526de674","after":"659f07e7775161d99e5747a2d732e2cc00806fa7","ref":"refs/heads/gh-pages","pushedAt":"2024-07-03T17:38:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Update documentation","shortMessageHtmlLink":"Update documentation"}},{"before":"63ccecaa2812c70aa7b2cda7a3a4b43abe0af223","after":"4e39b06c79660c86ebbab467ccfcd01a13857d93","ref":"refs/heads/main","pushedAt":"2024-07-03T17:37:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add Spark raise_error function (#10110)\n\nSummary:\nThis PR adds Spark `raise_error` function. It is re-used in Spark `assert_true`\nfunction, so after this PR `assert_true` can also be supported.\n\nSpark document: https://spark.apache.org/docs/latest/api/sql/#raise_error\nSpark code: https://github.com/apache/spark/blob/branch-3.5/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/misc.scala#L85C1-L92C1\nIssue: https://github.com/apache/incubator-gluten/issues/5991\n\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10110\n\nReviewed By: kevinwilfong\n\nDifferential Revision: D59252851\n\nPulled By: bikramSingh91\n\nfbshipit-source-id: d41347bed8265825bb415e8604179b38ecc89bc8","shortMessageHtmlLink":"Add Spark raise_error function (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2340668169\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10110\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10110/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10110\">#10110</a>)"}},{"before":"4d6dd724e9392fd919ea466a258e7630c30814a0","after":"4fbf1553f40157cf3f5edf6a70646440526de674","ref":"refs/heads/gh-pages","pushedAt":"2024-07-03T04:58:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Update build metrics","shortMessageHtmlLink":"Update build metrics"}},{"before":"4a0ce3e4320ed338f1e5291960474be7bf537195","after":"63ccecaa2812c70aa7b2cda7a3a4b43abe0af223","ref":"refs/heads/main","pushedAt":"2024-07-03T01:58:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Check determinism using function name only (#10241)\n\nSummary:\nIn ExpressionFuzzer, the determinism could be decided without argument\ntypes. This PR changes to check determinism using function name only by\nfetching all registry entries for the given function name and checking if all\nof them are deterministic. The function is deterministic if \"deterministic\" is\ntrue for every entry. With this change, argument types are not required when\nthe signature variables are not empty.\n\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10241\n\nReviewed By: pedroerp\n\nDifferential Revision: D59122132\n\nPulled By: bikramSingh91\n\nfbshipit-source-id: ab3c2907f102d3ebb81269fe58499bef0bb878ab","shortMessageHtmlLink":"Check determinism using function name only (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2358755437\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10241\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10241/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10241\">#10241</a>)"}},{"before":"5bc1deb48aee81550aedbb5917bab01d3a4b61ae","after":"4d6dd724e9392fd919ea466a258e7630c30814a0","ref":"refs/heads/gh-pages","pushedAt":"2024-07-02T22:41:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Update documentation","shortMessageHtmlLink":"Update documentation"}},{"before":"49407ff9fc3f4559a1574e8cab7c964641dea6fe","after":"4a0ce3e4320ed338f1e5291960474be7bf537195","ref":"refs/heads/main","pushedAt":"2024-07-02T22:40:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Replace MappedMemory::Allocation with memory::Allocation in comments (#10336)\n\nSummary: Pull Request resolved: https://github.com/facebookincubator/velox/pull/10336\n\nReviewed By: pedroerp\n\nDifferential Revision: D59285314\n\nPulled By: bikramSingh91\n\nfbshipit-source-id: 18737182a28d63eea6a8ccc4ab8f6145027f320a","shortMessageHtmlLink":"Replace MappedMemory::Allocation with memory::Allocation in comments (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2377266679\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10336\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10336/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10336\">#…</a>"}},{"before":"b29176d6ba64a993ed199bb345de056736079968","after":"49407ff9fc3f4559a1574e8cab7c964641dea6fe","ref":"refs/heads/main","pushedAt":"2024-07-02T22:30:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add argument generator for Presto truncate decimal function (#10245)\n\nSummary:\nRequired by decimal fuzzer test to generate correct argument types for Presto\ntruncate decimal function following specified constraints. Only the single-arg\ntruncate function is supported because ArgumentTypeFuzzer can generate argument\ntypes for the two-arg truncate function.\nhttps://github.com/facebookincubator/velox/pull/10217\n\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10245\n\nReviewed By: pedroerp\n\nDifferential Revision: D59122052\n\nPulled By: bikramSingh91\n\nfbshipit-source-id: cfd606100c2e8001c749d906b92b271e674fa8e7","shortMessageHtmlLink":"Add argument generator for Presto truncate decimal function (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2359129246\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10245\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10245/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10245\">#10245</a>)"}},{"before":"f5bfd1eed38780597b3b13eff1370207f67f0838","after":"b29176d6ba64a993ed199bb345de056736079968","ref":"refs/heads/main","pushedAt":"2024-07-02T22:24:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix spark-server docker image (#10356)\n\nSummary:\nOn centos 9, below exception is noticed when starting Spark if putting\n`SPARK_CONNECT_JAR` under `${SPARK_HOME}/jars/`. This PR moves it in\n`${SPARK_HOME}/misc/` to avoid the incompatibility.\n```\nException in thread \"main\" java.lang.NoClassDefFoundError: org/sparkproject/guava/util/concurrent/internal/InternalFutureFailureAccess\n\tat java.base/java.lang.ClassLoader.defineClass1(Native Method)\n\tat java.base/java.lang.ClassLoader.defineClass(ClassLoader.java:1022)\n\tat java.base/java.security.SecureClassLoader.defineClass(SecureClassLoader.java:174)\n\tat java.base/jdk.internal.loader.BuiltinClassLoader.defineClass(BuiltinClassLoader.java:800)\n\tat java.base/\n```\nhttps://github.com/facebookincubator/velox/pull/9559\n\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10356\n\nReviewed By: pedroerp\n\nDifferential Revision: D59285334\n\nPulled By: bikramSingh91\n\nfbshipit-source-id: 98212006c33581b7e5e56c9bd838c31c64de577e","shortMessageHtmlLink":"Fix spark-server docker image (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2383012370\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10356\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10356/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10356\">#10356</a>)"}},{"before":null,"after":"2bb7f6d502b96988600e5ba6d8cd48d65d7c5e7d","ref":"refs/heads/exchange_unused","pushedAt":"2024-07-02T22:16:10.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"aditi-pandit","name":"Aditi Pandit","path":"/aditi-pandit","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/87670623?s=80&v=4"},"commit":{"message":"Remove unused method in ExchangeSource","shortMessageHtmlLink":"Remove unused method in ExchangeSource"}},{"before":"8fcd7c58e32d8c5ba03e1fcfe4d05647e148e87c","after":"f5bfd1eed38780597b3b13eff1370207f67f0838","ref":"refs/heads/main","pushedAt":"2024-07-02T20:11:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix incorrect result of approx_percentile in window operations (#10368)\n\nSummary:\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10368\n\napprox_percentile(x, percentiles) returns incorrect result in a window\noperation where a frame that should return non-NULL follows a frame\nthat returns NULL. Before the fix, the window operation returns NULL\nfor both frames. This is because\nAggregationWindowFunction::computeAggregate() reuses the same\nresult vector across frames. It calls BaseVector::prepareForReuse()\nbefore computing the aggregation for a frame. prepareForReuse()\ndoesn't clear the nulls buffer of the vector as it expects the code that\nreuse the vector to set nulls properly. ApproxPercentileAggregate,\nhowever, doesn't set the result rows to be non-null in the code path\nfor array-typed percentiles.\n\nThis diff fixes this bug by setting the nulls buffer properly.\n\nReviewed By: Yuhta\n\nDifferential Revision: D59257658\n\nfbshipit-source-id: 1e114dad3a61401eb90292a4b40a662708dfe6a5","shortMessageHtmlLink":"Fix incorrect result of approx_percentile in window operations (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2385098806\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10368\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10368/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10368\">#10368</a>)"}},{"before":"c12aa738bc1354def5850f1b21d676cd98ceff2a","after":"8fcd7c58e32d8c5ba03e1fcfe4d05647e148e87c","ref":"refs/heads/main","pushedAt":"2024-07-02T18:08:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Improve the performance of hash Spark functions for scalar types through auto-vectorization (#10301)\n\nSummary:\nImprove the performance of hash Spark functions for scalar types through\nauto-vectorization.\nWe can observe a measurable speed-up with this change:\nTINYINT: ~4X, SMALLINT: ~4X, BIGINT: ~2X, REAL: ~4X, DOUBLE:~2X,\nDECIMAL(18, 6): ~2X, DECIMAL(38, 6): ~1.2X, TIMESTAMP: ~1.8X,\nVARCHAR: ~1.3X.\n\nBenchmark result before this optimization:\n```\n============================================================================\n[...]hmarks/ExpressionBenchmarkBuilder.cpp     relative  time/iter   iters/s\n============================================================================\nhash#ARRAY<MAP<INTEGER,VARCHAR>>#0%nulls##hash              8.33ms    120.03\nhash#ARRAY<MAP<INTEGER,VARCHAR>>#0%nulls##xxhas             8.62ms    116.06\n----------------------------------------------------------------------------\nhash#ARRAY<MAP<INTEGER,VARCHAR>>https://github.com/facebookincubator/velox/issues/25%nulls##hash             4.76ms    210.08\nhash#ARRAY<MAP<INTEGER,VARCHAR>>https://github.com/facebookincubator/velox/issues/25%nulls##xxha             5.17ms    193.50\n----------------------------------------------------------------------------\nhash#BIGINT#0%nulls##hash                                   1.42ms    706.16\nhash#BIGINT#0%nulls##xxhash64                               1.44ms    695.32\n----------------------------------------------------------------------------\nhash#BIGINT#25%nulls##hash                                  1.26ms    791.56\nhash#BIGINT#25%nulls##xxhash64                              1.28ms    779.92\n----------------------------------------------------------------------------\nhash#DECIMAL(18, 6)#0%nulls##hash                           1.41ms    708.28\nhash#DECIMAL(18, 6)#0%nulls##xxhash64                       1.44ms    694.50\n----------------------------------------------------------------------------\nhash#DECIMAL(18, 6)https://github.com/facebookincubator/velox/issues/25%nulls##hash                          1.26ms    792.73\nhash#DECIMAL(18, 6)https://github.com/facebookincubator/velox/issues/25%nulls##xxhash64                      1.28ms    783.60\n----------------------------------------------------------------------------\nhash#DECIMAL(38, 6)#0%nulls##hash                           3.26ms    306.97\nhash#DECIMAL(38, 6)#0%nulls##xxhash64                       3.10ms    322.95\n----------------------------------------------------------------------------\nhash#DECIMAL(38, 6)https://github.com/facebookincubator/velox/issues/25%nulls##hash                          2.66ms    376.15\nhash#DECIMAL(38, 6)https://github.com/facebookincubator/velox/issues/25%nulls##xxhash64                      2.52ms    396.68\n----------------------------------------------------------------------------\nhash#DOUBLE#0%nulls##hash                                   1.49ms    670.95\nhash#DOUBLE#0%nulls##xxhash64                               1.55ms    646.38\n----------------------------------------------------------------------------\nhash#DOUBLE#25%nulls##hash                                  1.33ms    750.15\nhash#DOUBLE#25%nulls##xxhash64                              1.36ms    737.38\n----------------------------------------------------------------------------\nhash#REAL#0%nulls##hash                                     1.40ms    714.23\nhash#REAL#0%nulls##xxhash64                                 1.53ms    654.87\n----------------------------------------------------------------------------\nhash#REAL#25%nulls##hash                                    1.24ms    804.34\nhash#REAL#25%nulls##xxhash64                                1.33ms    750.28\n----------------------------------------------------------------------------\nhash#ROW<f_map:MAP<INTEGER,VARCHAR>,f_array:ARR            15.46ms     64.68\nhash#ROW<f_map:MAP<INTEGER,VARCHAR>,f_array:ARR            14.41ms     69.42\n----------------------------------------------------------------------------\nhash#ROW<f_map:MAP<INTEGER,VARCHAR>,f_array:ARR             9.19ms    108.82\nhash#ROW<f_map:MAP<INTEGER,VARCHAR>,f_array:ARR             8.97ms    111.52\n----------------------------------------------------------------------------\nhash#SMALLINT#0%nulls##hash                                 1.30ms    769.77\nhash#SMALLINT#0%nulls##xxhash64                             1.38ms    724.97\n----------------------------------------------------------------------------\nhash#SMALLINT#25%nulls##hash                                1.16ms    865.78\nhash#SMALLINT#25%nulls##xxhash64                            1.22ms    820.72\n----------------------------------------------------------------------------\nhash#TIMESTAMP#0%nulls##hash                                2.04ms    490.14\nhash#TIMESTAMP#0%nulls##xxhash64                            2.02ms    495.06\n----------------------------------------------------------------------------\nhash#TIMESTAMP#25%nulls##hash                               1.70ms    587.79\nhash#TIMESTAMP#25%nulls##xxhash64                           1.71ms    584.17\n----------------------------------------------------------------------------\nhash#TINYINT#0%nulls##hash                                  1.30ms    768.66\nhash#TINYINT#0%nulls##xxhash64                              1.41ms    707.97\n----------------------------------------------------------------------------\nhash#TINYINT#25%nulls##hash                                 1.16ms    865.09\nhash#TINYINT#25%nulls##xxhash64                             1.21ms    823.21\n----------------------------------------------------------------------------\nhash#VARCHAR#0%nulls##hash                                  4.65ms    215.03\nhash#VARCHAR#0%nulls##xxhash64                              4.06ms    246.43\n----------------------------------------------------------------------------\nhash#VARCHAR#25%nulls##hash                                 3.79ms    263.59\nhash#VARCHAR#25%nulls##xxhash64                             3.35ms    298.64\n----------------------------------------------------------------------------\n```\nBenchmark result before after optimization:\n```\n============================================================================\n[...]hmarks/ExpressionBenchmarkBuilder.cpp     relative  time/iter   iters/s\n============================================================================\nhash#ARRAY<MAP<INTEGER,VARCHAR>>#0%nulls##hash              7.97ms    125.46\nhash#ARRAY<MAP<INTEGER,VARCHAR>>#0%nulls##xxhas             8.09ms    123.62\n----------------------------------------------------------------------------\nhash#ARRAY<MAP<INTEGER,VARCHAR>>https://github.com/facebookincubator/velox/issues/25%nulls##hash             4.15ms    240.78\nhash#ARRAY<MAP<INTEGER,VARCHAR>>https://github.com/facebookincubator/velox/issues/25%nulls##xxha             4.52ms    221.41\n----------------------------------------------------------------------------\nhash#BIGINT#0%nulls##hash                                 632.90us     1.58K\nhash#BIGINT#0%nulls##xxhash64                             550.34us     1.82K\n----------------------------------------------------------------------------\nhash#BIGINT#25%nulls##hash                                631.35us     1.58K\nhash#BIGINT#25%nulls##xxhash64                            528.26us     1.89K\n----------------------------------------------------------------------------\nhash#DECIMAL(18, 6)#0%nulls##hash                         620.12us     1.61K\nhash#DECIMAL(18, 6)#0%nulls##xxhash64                     542.33us     1.84K\n----------------------------------------------------------------------------\nhash#DECIMAL(18, 6)https://github.com/facebookincubator/velox/issues/25%nulls##hash                        646.62us     1.55K\nhash#DECIMAL(18, 6)https://github.com/facebookincubator/velox/issues/25%nulls##xxhash64                    531.15us     1.88K\n----------------------------------------------------------------------------\nhash#DECIMAL(38, 6)#0%nulls##hash                           2.21ms    452.26\nhash#DECIMAL(38, 6)#0%nulls##xxhash64                       2.24ms    447.31\n----------------------------------------------------------------------------\nhash#DECIMAL(38, 6)https://github.com/facebookincubator/velox/issues/25%nulls##hash                          1.98ms    504.33\nhash#DECIMAL(38, 6)https://github.com/facebookincubator/velox/issues/25%nulls##xxhash64                      1.79ms    559.13\n----------------------------------------------------------------------------\nhash#DOUBLE#0%nulls##hash                                 697.29us     1.43K\nhash#DOUBLE#0%nulls##xxhash64                             555.24us     1.80K\n----------------------------------------------------------------------------\nhash#DOUBLE#25%nulls##hash                                715.82us     1.40K\nhash#DOUBLE#25%nulls##xxhash64                            573.07us     1.74K\n----------------------------------------------------------------------------\nhash#REAL#0%nulls##hash                                   241.69us     4.14K\nhash#REAL#0%nulls##xxhash64                               461.39us     2.17K\n----------------------------------------------------------------------------\nhash#REAL#25%nulls##hash                                  548.04us     1.82K\nhash#REAL#25%nulls##xxhash64                              561.36us     1.78K\n----------------------------------------------------------------------------\nhash#ROW<f_map:MAP<INTEGER,VARCHAR>,f_array:ARR            13.80ms     72.46\nhash#ROW<f_map:MAP<INTEGER,VARCHAR>,f_array:ARR            13.90ms     71.97\n----------------------------------------------------------------------------\nhash#ROW<f_map:MAP<INTEGER,VARCHAR>,f_array:ARR             8.69ms    115.07\nhash#ROW<f_map:MAP<INTEGER,VARCHAR>,f_array:ARR             8.49ms    117.74\n----------------------------------------------------------------------------\nhash#SMALLINT#0%nulls##hash                               232.45us     4.30K\nhash#SMALLINT#0%nulls##xxhash64                           429.04us     2.33K\n----------------------------------------------------------------------------\nhash#SMALLINT#25%nulls##hash                              468.51us     2.13K\nhash#SMALLINT#25%nulls##xxhash64                          482.70us     2.07K\n----------------------------------------------------------------------------\nhash#TIMESTAMP#0%nulls##hash                                1.07ms    936.71\nhash#TIMESTAMP#0%nulls##xxhash64                          979.66us     1.02K\n----------------------------------------------------------------------------\nhash#TIMESTAMP#25%nulls##hash                             999.56us     1.00K\nhash#TIMESTAMP#25%nulls##xxhash64                         873.88us     1.14K\n----------------------------------------------------------------------------\nhash#TINYINT#0%nulls##hash                                235.68us     4.24K\nhash#TINYINT#0%nulls##xxhash64                            420.17us     2.38K\n----------------------------------------------------------------------------\nhash#TINYINT#25%nulls##hash                               468.88us     2.13K\nhash#TINYINT#25%nulls##xxhash64                           469.59us     2.13K\n----------------------------------------------------------------------------\nhash#VARCHAR#0%nulls##hash                                  3.40ms    293.97\nhash#VARCHAR#0%nulls##xxhash64                              2.97ms    336.20\n----------------------------------------------------------------------------\nhash#VARCHAR#25%nulls##hash                                 2.89ms    346.43\nhash#VARCHAR#25%nulls##xxhash64                             2.86ms    349.69\n----------------------------------------------------------------------------\n\n```\n\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10301\n\nReviewed By: Yuhta\n\nDifferential Revision: D59252777\n\nPulled By: bikramSingh91\n\nfbshipit-source-id: 5ad516fe0df82df6fc0c1568bb04a0fd63664d92","shortMessageHtmlLink":"Improve the performance of hash Spark functions for scalar types thro…"}},{"before":"64dc8f33f6a647a08c2124bd4b001f921928a47e","after":"c12aa738bc1354def5850f1b21d676cd98ceff2a","ref":"refs/heads/main","pushedAt":"2024-07-02T18:03:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix GroupIdNode`s groupIdName to const method (#10345)\n\nSummary:\nFix GroupIdNode`s groupIdName() to const method, so that it could be access by NodePtr.\n\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10345\n\nReviewed By: amitkdutta\n\nDifferential Revision: D59252706\n\nPulled By: bikramSingh91\n\nfbshipit-source-id: 4bcb62f5904ac2c476695f51ee4e31cee60f7dbb","shortMessageHtmlLink":"Fix GroupIdNode`s groupIdName to const method (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2379842197\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10345\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10345/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10345\">#10345</a>)"}},{"before":"c265fcf16be9f8c013beba149d6571c290eb9331","after":"64dc8f33f6a647a08c2124bd4b001f921928a47e","ref":"refs/heads/main","pushedAt":"2024-07-02T16:02:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Code formatting in velox/dwio/common (#10369)\n\nSummary:\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10369\n\nJust some code formatting to make sure it follows Velox's coding\nguidelines, in preparation for upcoming changes.\n\nReviewed By: amitkdutta\n\nDifferential Revision: D59258672\n\nfbshipit-source-id: 6fa1d6ed79bf8dbe43aa21960d1d9616ec6d667c","shortMessageHtmlLink":"Code formatting in velox/dwio/common (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2385133905\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10369\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10369/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10369\">#10369</a>)"}},{"before":"6caa7d5351ef4a83acfaebaab7b4389ae3231421","after":"c265fcf16be9f8c013beba149d6571c290eb9331","ref":"refs/heads/main","pushedAt":"2024-07-02T15:56:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Cosmetic refactor on merge join supported types (#10366)\n\nSummary:\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10366\n\nCosmetic refactor on merge join supported types\n\nReviewed By: xiaoxmeng\n\nDifferential Revision: D59252668\n\nfbshipit-source-id: c27f2f049fd9981f9c8f830eb236fda114cc02f1","shortMessageHtmlLink":"Cosmetic refactor on merge join supported types (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2384923227\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10366\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10366/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10366\">#10366</a>)"}},{"before":"12ee18a8cb9de45c502c14a73c42a3bdb8c57ef2","after":"5bc1deb48aee81550aedbb5917bab01d3a4b61ae","ref":"refs/heads/gh-pages","pushedAt":"2024-07-02T04:56:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Update build metrics","shortMessageHtmlLink":"Update build metrics"}},{"before":"181c6aec148d15581aabe2673fbcd7a582bc1cc9","after":"6caa7d5351ef4a83acfaebaab7b4389ae3231421","ref":"refs/heads/main","pushedAt":"2024-07-01T22:36:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add max spill level in RowNumber fuzzer (#10347)\n\nSummary:\nAdd a max spill level config in the RowNumberFuzzer.\n\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10347\n\nReviewed By: tanjialiang\n\nDifferential Revision: D59232589\n\nPulled By: xiaoxmeng\n\nfbshipit-source-id: 95a2d37d387c5767cb61444d37a154d936571a2b","shortMessageHtmlLink":"Add max spill level in RowNumber fuzzer (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2380721159\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10347\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10347/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10347\">#10347</a>)"}},{"before":"f9c01edb0d65daf665f0f54955dad0a57b56677c","after":"12ee18a8cb9de45c502c14a73c42a3bdb8c57ef2","ref":"refs/heads/gh-pages","pushedAt":"2024-07-01T22:03:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"github-actions[bot]","name":null,"path":"/apps/github-actions","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/15368?s=80&v=4"},"commit":{"message":"Update documentation","shortMessageHtmlLink":"Update documentation"}},{"before":"4f532a033203387f61a11f60333722158eb2063b","after":"181c6aec148d15581aabe2673fbcd7a582bc1cc9","ref":"refs/heads/main","pushedAt":"2024-07-01T22:02:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add secure_random() and secure_random(lower,upper) Presto functions (#9295)\n\nSummary:\nhttps://github.com/facebookincubator/velox/issues/5762\nhttps://github.com/prestodb/presto/issues/20530\n\nPull Request resolved: https://github.com/facebookincubator/velox/pull/9295\n\nReviewed By: amitkdutta\n\nDifferential Revision: D58423391\n\nPulled By: kevinwilfong\n\nfbshipit-source-id: 93d30d872b5a1924c86cb1f2c2d4c057ee91d02a","shortMessageHtmlLink":"Add secure_random() and secure_random(lower,upper) Presto functions (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2214181439\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/9295\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/9295/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/9295\">#…</a>"}},{"before":"02dca9d39e3010d65893db1f9715a7af6356e63c","after":"4f532a033203387f61a11f60333722158eb2063b","ref":"refs/heads/main","pushedAt":"2024-07-01T21:51:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix failing Linux release with adapters (#10360)\n\nSummary:\nThis is a temporary workaround.\nThe actual fix is to build and install thrift.\n\nResolves https://github.com/facebookincubator/velox/issues/10352\n\nPull Request resolved: https://github.com/facebookincubator/velox/pull/10360\n\nReviewed By: amitkdutta\n\nDifferential Revision: D59239687\n\nPulled By: pedroerp\n\nfbshipit-source-id: 733268cab0742444e6fd637854b711f918308299","shortMessageHtmlLink":"Fix failing Linux release with adapters (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2383496289\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebookincubator/velox/issues/10360\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebookincubator/velox/pull/10360/hovercard\" href=\"https://github.com/facebookincubator/velox/pull/10360\">#10360</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEdpaLVwA","startCursor":null,"endCursor":null}},"title":"Activity · facebookincubator/velox"}