Adapters build broken due to new images ?

[kgpai]

Problem description

Looks like the new adapters build are failing with the following error:

CMake Error at /usr/local/lib64/python3.9/site-packages/cmake/data/share/cmake-3.30/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  By not providing "FindXxhash.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Xxhash", but
  CMake did not find one.

  Could not find a package configuration file provided by "Xxhash" with any
  of the following names:

    XxhashConfig.cmake
    xxhash-config.cmake

  Add the installation prefix of "Xxhash" to CMAKE_PREFIX_PATH or set
  "Xxhash_DIR" to a directory containing one of the above files.  If "Xxhash"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  /usr/local/lib/cmake/fbthrift/FBThriftConfig.cmake:56 (find_dependency)
  CMakeLists.txt:559 (find_package)

System information

https://github.com/facebookincubator/velox/actions/runs/14652598513/job/41121663534?pr=13126

CMake log

[kgpai]

cc: @czentgr @assignUser @majetideepak

[kgpai]

This could possibly have broken it : #13016

[kou]

I think that this is a problem of https://github.com/facebook/fbthrift .

facebook/fbthrift@a6e835d added find_dependency(Xxhash REQUIRED) to thrift/cmake/FBThriftConfig.cmake.in but build/fbcode_builder/CMake/FindXxhash.cmake used by find_dependency(Xxhash REQUIRED) isn't installed.

[kou]

facebook/fbthrift#651

[majetideepak]

Thanks @kou for the fix! Let's patch Velox with https://github.com/facebook/fbthrift/pull/651/files and then update when fbthrift is fixed.

[majetideepak]

This is not via fbthrift bundling. We cannot add this patch. A workaround is to disable remote functions for now and upgrade fbthrift.
#13156

[majetideepak]

We will have issues with Prestissimo build. Let's move the version to a week before to avoid this change https://github.com/facebook/fbthrift/releases/tag/v2025.03.31.00

[majetideepak]

I have another fix here #13157