Skip to content

Commit b7c3743

Browse files
committed
Add test checking config is unchanged
1 parent 1eba8e1 commit b7c3743

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

tests/instantiate/test_instantiate.py

+22
Original file line numberDiff line numberDiff line change
@@ -419,8 +419,10 @@ def test_class_instantiate(
419419
recursive: bool,
420420
) -> Any:
421421
passthrough["_recursive_"] = recursive
422+
original_config_str = str(config)
422423
obj = instantiate_func(config, **passthrough)
423424
assert partial_equal(obj, expected)
425+
assert str(config) == original_config_str
424426

425427

426428
def test_partial_with_missing(instantiate_func: Any) -> Any:
@@ -431,10 +433,12 @@ def test_partial_with_missing(instantiate_func: Any) -> Any:
431433
"b": 20,
432434
"c": 30,
433435
}
436+
original_config_str = str(config)
434437
partial_obj = instantiate_func(config)
435438
assert partial_equal(partial_obj, partial(AClass, b=20, c=30))
436439
obj = partial_obj(a=10)
437440
assert partial_equal(obj, AClass(a=10, b=20, c=30))
441+
assert str(config) == original_config_str
438442

439443

440444
def test_instantiate_with_missing(instantiate_func: Any) -> Any:
@@ -468,6 +472,7 @@ def test_none_cases(
468472
ListConfig(None),
469473
],
470474
}
475+
original_config_str = str(cfg)
471476
ret = instantiate_func(cfg)
472477
assert ret.kwargs["none_dict"] is None
473478
assert ret.kwargs["none_list"] is None
@@ -477,6 +482,7 @@ def test_none_cases(
477482
assert ret.kwargs["list"][0] == 10
478483
assert ret.kwargs["list"][1] is None
479484
assert ret.kwargs["list"][2] is None
485+
assert str(cfg) == original_config_str
480486

481487

482488
@mark.parametrize(
@@ -537,6 +543,20 @@ def test_none_cases(
537543
6,
538544
id="interpolation_from_recursive",
539545
),
546+
param(
547+
{
548+
"my_id": 5,
549+
"node": {
550+
"b": "${foo_b}",
551+
},
552+
"foo_b": {
553+
"unique_id": "${my_id}",
554+
},
555+
},
556+
{},
557+
OmegaConf.create({"b": {"unique_id": 5}}),
558+
id="interpolation_from_parent_with_interpolation",
559+
),
540560
],
541561
)
542562
def test_interpolation_accessing_parent(
@@ -547,12 +567,14 @@ def test_interpolation_accessing_parent(
547567
) -> Any:
548568
cfg_copy = OmegaConf.create(input_conf)
549569
input_conf = OmegaConf.create(input_conf)
570+
original_config_str = str(input_conf)
550571
obj = instantiate_func(input_conf.node, **passthrough)
551572
if isinstance(expected, partial):
552573
assert partial_equal(obj, expected)
553574
else:
554575
assert obj == expected
555576
assert input_conf == cfg_copy
577+
assert str(input_conf) == original_config_str
556578

557579

558580
@mark.parametrize(

0 commit comments

Comments
 (0)