Comment out _set_parent call in instantiate function

jesszzzz · jesszzzz · commit f129beeed007 · 2025-01-03T11:58:10.000-05:00
Use deepcopied parent in instantiate instead of old parent to avoid unexpected side effects
diff --git a/hydra/_internal/instantiate/_instantiate2.py b/hydra/_internal/instantiate/_instantiate2.py
@@ -211,7 +211,6 @@ def instantiate(config: Any, *args: Any, **kwargs: Any) -> Any:
         config_copy._set_flag(
             flags=["allow_objects", "struct", "readonly"], values=[True, False, False]
         )
-        config_copy._set_parent(config._get_parent())
         config = config_copy
 
         if kwargs:
@@ -232,7 +231,6 @@ def instantiate(config: Any, *args: Any, **kwargs: Any) -> Any:
         config_copy._set_flag(
             flags=["allow_objects", "struct", "readonly"], values=[True, False, False]
         )
-        config_copy._set_parent(config._get_parent())
         config = config_copy
 
         OmegaConf.resolve(config)

Original file line number	Diff line number	Diff line change
`@@ -211,7 +211,6 @@ def instantiate(config: Any, args: Any, *kwargs: Any) -> Any:`
`211`	`211`	`config_copy._set_flag(`
`212`	`212`	`flags=["allow_objects", "struct", "readonly"], values=[True, False, False]`
`213`	`213`	`)`
`214`		`- config_copy._set_parent(config._get_parent())`
`215`	`214`	`config = config_copy`
`216`	`215`
`217`	`216`	`if kwargs:`
`@@ -232,7 +231,6 @@ def instantiate(config: Any, args: Any, *kwargs: Any) -> Any:`
`232`	`231`	`config_copy._set_flag(`
`233`	`232`	`flags=["allow_objects", "struct", "readonly"], values=[True, False, False]`
`234`	`233`	`)`
`235`		`- config_copy._set_parent(config._get_parent())`
`236`	`234`	`config = config_copy`
`237`	`235`
`238`	`236`	`OmegaConf.resolve(config)`