Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test descriptions #48

Open
emilyb7 opened this issue Jul 13, 2017 · 1 comment
Open

Test descriptions #48

emilyb7 opened this issue Jul 13, 2017 · 1 comment
Assignees

Comments

@emilyb7
Copy link

emilyb7 commented Jul 13, 2017

Hi team : )

Your tests would be cooler if you were very explicit about what you're testing.

E.g. for your marktodo tests... (218)

  • You could group all of these tests into one block
  • Get rid of the comments! (especially the // up to here //s - that really is quite confusing)
  • Use the description at the start of the test block to write something very clear like "marktodo takes an array of all todos and the id of the todo we want to change, and it returns an updated list with the selected todo marked as done or undone"
  • Then use the 3rd argument to t.deepEqual(...) to describe what should happen in each individual test

Hope that makes some sense??

@mattlub
Copy link

mattlub commented Jul 13, 2017

Then use the 3rd argument to t.deepEqual(...) to describe what should happen in each individual test

^^ I was just about to leave an issue for exactly this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants