Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navbar in index.html is not semantic #25

Open
mattlub opened this issue Jul 6, 2017 · 1 comment
Open

navbar in index.html is not semantic #25

mattlub opened this issue Jul 6, 2017 · 1 comment
Assignees
@mattlub @Heathercoraje

Comments

@mattlub
Copy link

mattlub commented Jul 6, 2017

See here

Your navbar could be written more semantically, e.g. using a 'nav' html element.

more info here:
https://codepen.io/mi-lee/post/an-overview-of-html5-semantics
@Heathercoraje Heathercoraje self-assigned this Jul 6, 2017
Heathercoraje pushed a commit that referenced this issue Jul 6, 2017
edit div to navfor nav bar
4d0eb99 
relates #25
Heathercoraje pushed a commit that referenced this issue Jul 6, 2017
edit nav var
14ab5c6 
relates #25
@Heathercoraje
Copy link
Collaborator

The div tag for navigation bar has been changed to nav tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattlub mattlub

@Heathercoraje Heathercoraje

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattlub @Heathercoraje