Update entrypoint and readme to improve quick-start. #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Fank any interest in getting this merged? |
| @@ -53,6 +54,7 @@ sudo docker run -d \ | |||
| For those new to Docker, here is an explanation of the options: | |||
|
|
|||
| * `-d` - Run as a daemon ("detached"). | |||
| * `-it` - Interactive mode. | |||
There was a problem hiding this comment.
That is so incorrect. -i is interactive and -t allocates a tty.
| ``` | ||
|
|
||
| To detach and return to outside docker, use Ctrl-P + CTRL-Q. |
There was a problem hiding this comment.
You are sure this is not shell depended?
| @@ -21,7 +21,8 @@ fi | |||
|
|
|||
| if [[ ! -f $CONFIG/server-settings.json ]]; then | |||
| # Copy default settings if server-settings.json doesn't exist | |||
| cp /opt/factorio/data/server-settings.example.json "$CONFIG/server-settings.json" | |||
| # edit the default visibility setting from public: true to public: false | |||
| cat /opt/factorio/data/server-settings.example.json | sed 's/ "public": true/ "public": false/' > "$CONFIG/server-settings.json" | |||
|
Also please cleanup the commit history. |
|
Closing as this is now stale. Feel free to take it over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #450.
Should make the quick start copy-paste snippet "just work".