add $key for all object and support private class name #32

thesadboy · 2021-11-30T10:16:12Z

As the readme file shows, add $key for all object, not only in array. The $key value support private ClassName start by _ .

etoiledemer · 2021-11-30T18:24:57Z

i like that 👍

etoiledemer · 2021-12-20T20:25:23Z

@mark-apn can we merge this?

mark-nicepants · 2022-05-30T18:09:50Z

Sorry for keeping you waiting. I'll take a look at this this week!

mark-nicepants · 2022-06-01T07:41:09Z

Question about this PR.

Why not just change the key in the json in the first place.

{
   "movie": {
      "id": 123
   }
}

Will generate a Movie class and by changing the key movie you change the key in the output.

Why do we need this:

{
   "movie": {
      "$key":  "film",
      "id": 123,
   }
}

When we can just do this.

{
   "film": {
      "id": 123
   }
}

etoiledemer · 2022-06-08T00:21:00Z

if I remember correctly it helps fixing this : #30
without having to use separate files;

(when we have two keys with same name, but with different properties, it avoid name clashes in generated files)

add $key for all object and support private class name

a4651b2

Provide feedback