Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4pt] Staging settings with a commit token #174

Open
vimpostor opened this issue Sep 29, 2023 · 0 comments
Open

[4pt] Staging settings with a commit token #174

vimpostor opened this issue Sep 29, 2023 · 0 comments
Assignees

Comments

@vimpostor
Copy link
Contributor

Right now the multiplexed settings only have a single storage of all the active settings.
As detailed in #99 (review), a new "staging" API could allow staging settings with a commit token (e.g. a std::string) such that they are first stored in a background "staging" collection, instead of in the active settings collection.

Then later on, the staged settings can be transported to the actually active collection of the ctx_settings via multiple ways:

  • It could be activated explicitly through the settings API by passing the unique commit token
  • Implicit activation via a tag_t on one of the streaming ports
  • Implicit activation via a pmt_t message on one of the message ports

Some things to consider:

  • Before staging the settings, they should be validated, i.e. check if the keys actually map to existing struct member fields in the node and check for correct types and potential Range constraints (e.g. a field might want to only accept positive integers)
  • Instead of using just a simple string as a commit token, we potentially might want to generate a unique hash - in a git-like fashion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants