Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add msg port support to GRC de/serialization #265

Open
frankosterfeld opened this issue Feb 6, 2024 · 0 comments
Open

Add msg port support to GRC de/serialization #265

frankosterfeld opened this issue Feb 6, 2024 · 0 comments

Comments

@frankosterfeld
Copy link
Contributor

frankosterfeld commented Feb 6, 2024

When I add custom msgIn/out ports and connect them, I get ports with subindex in the connections, like [1, 0], ..., [1, 1]. This seems wrong and fails on load, as msg ports have no subindexes.
I would suggest we follow the old grc format from GR3 and support port names in the connections section, like

 - [foo, '0',  bar, '5'] # streaming ports referenced by index
 - [foo, ['0', '4'], bar, ['1', '3']] # streaming port collections (should the subindex be quoted??)
 - [foo, [out, '4'], bar, [in, '3']] # streaming port collections using names
 - [foo, msgOut, bar, msgIn ] # connecting msg ports, by name

That way streaming and msg port indexes wouldn't be mixed up, and the yaml would be easier to read, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant