Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3pt] graph-prototype: Consolidate UT-based tests and test applications #97

Closed
ivan-cukic opened this issue Jun 21, 2023 · 3 comments
Closed

Comments

@ivan-cukic
Copy link
Contributor

ivan-cukic commented Jun 21, 2023

There is a lot of copy-paste code in the tests. Especially in the separate applications (test/app_*.cpp). The reason for the current test applications are issues with uT.

@RalphSteinhagen
Copy link
Member

This is likely linked and/or could be combined with: fair-acc/opendigitizer#91

@wirew0rm, what do you think?

@wirew0rm
Copy link
Member

I think it's more related to #125 at least from the title?

Sounds like we have to either fix the issues with UT (mentioned issue) or add some light abstractions to reuse code between ut tests and test apps (this issue). The block refactoring tackles another kind of duplication? There is some overlap in in the files this touches, but conceptually the issues are different and #91 is simple refactoring while this one needs investigation and possibly fixes on the UT side, so I think it's easier to leave them separate for now. (Always possible to fix both in a single PR)

@RalphSteinhagen RalphSteinhagen changed the title graph-prototype: Consolidate UT-based tests and test applications [3pt] graph-prototype: Consolidate UT-based tests and test applications Jul 21, 2023
@RalphSteinhagen
Copy link
Member

done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA-Accepted/Merged (∞)
Development

No branches or pull requests

3 participants