Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5pt] graph-prototype: Port unported blocks #116

Closed
1 of 8 tasks
frankosterfeld opened this issue Dec 1, 2022 · 2 comments
Closed
1 of 8 tasks

[5pt] graph-prototype: Port unported blocks #116

frankosterfeld opened this issue Dec 1, 2022 · 2 comments

Comments

@frankosterfeld
Copy link

frankosterfeld commented Dec 1, 2022

Port - or declare abandoned - the following blocks:

  • cascade_sink (old implementation mostly commented out) -> to be implemented as sub-graphs in the new graph-prototype/GR 4.0 framework
  • block_aggregation,
  • block_amplitude_and_phase,
  • block_complex_to_mag -> @drslebedev
  • block_custom_filter,
  • amplitude_phase_adjuster,
  • amplitude_and_phase_helper (some are helper blocks, some are hier blocks using old GR3 blocks not yet ported, etc.)
  • stft_algorithms (convenience hier block) -> @drslebedev

blocks shall become core of graph-prototype/GR4.0

@frankosterfeld frankosterfeld changed the title Port unported blocks dev-4.0: Port unported blocks Dec 2, 2022
RalphSteinhagen pushed a commit that referenced this issue Dec 2, 2022
* Port of gr-digitizer to GNU Radio 4.0

Make code compile with GR 4.0, latest ROOT and latest Picoscope drivers. Some tests don't pass atm.

open issues/improvements to be followed-up later:
#110
#111
#112
#113 
#114 
#115 
#116 

Co-authored-by: Alexander Krimm <[email protected]>
@alexxcons
Copy link
Collaborator

cascade_sink (old implementation mostly commented out)

One of the most used blocks in the currently running Digitizer Flowgraphs. You can take a look on all used flowgraphs here:

https://gitlab.com/al.schwinn/DigitizerDU2/-/tree/master/src/test

Postmortem sinks, interlock sinks and frequency sinks currently are disabled / untested, since not used with the current FESA software. Insufficient manpower to integrate them. Though afaik with the new opencmw implementation, these as well should be taken into operation.

So if you plan to abandon the Cascade Sink, I suppose we would need some replacement. (I suppose the use-case this sink fulfills could as well be solved by using hieratical blocks)

block_aggregation

Used inside the cascade sink, so same as above.

block_amplitude_and_phase, block_complex_to_mag, amplitude_phase_adjuster, amplitude_and_phase_helper

To be used inside dal009 ... dal014 (In order to measure and compare HF frequencies). Some of these blocks are currently disabled in the flowgraphs, since they cause performance problems.

block_custom_filter,

Afaik currently unused, though not sure.

stft_algorithms (convenience hier block)

Currently used for multiple scopes which measure in triggered mode: dal005, dal006, dal027, fel0013 ... e.g. for the schottky_band_pass_filter

@RalphSteinhagen RalphSteinhagen changed the title dev-4.0: Port unported blocks [] graph-prototype: Port unported blocks Jul 15, 2023
@RalphSteinhagen RalphSteinhagen changed the title [] graph-prototype: Port unported blocks [5pt] graph-prototype: Port unported blocks Jul 21, 2023
@RalphSteinhagen
Copy link
Member

Largely being implemented and further blocks being tracked by this EPIC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA-Accepted/Merged (∞)
Development

No branches or pull requests

3 participants