Merge pull request #356 from fairdataihub/advanced-banner-img-fix

fix: banner image modals not appearing

Author: aaronm-2112

src/renderer/src/scripts/advanced-features/advanced_features.js

@@ -307,3 +307,12 @@ $("#advanced-start-over-button").on("click", async () => {
     document.querySelector("#compare-local-remote-dataset-question-3").style.display = "none";
   }
 });
+
+// Action when user click on "Import image" button for banner image
+$("#button-import-banner-image").click(async () => {
+  $("#para-dataset-banner-image-status").html("");
+  let filePaths = await window.electron.ipcRenderer.invoke("open-file-dialog-import-banner-image");
+  window.handleSelectedBannerImage(filePaths, "freeform");
+  $("#edit_banner_image_modal").modal("show");
+  $("#edit_banner_image_modal").addClass("show");
+});

src/renderer/src/scripts/manage-dataset/manage-dataset.js

@@ -1931,15 +1931,6 @@ const displayBannerImage = async (bannerImagePath) => {
   }
 };
 
-// Action when user click on "Import image" button for banner image
-$("#button-import-banner-image").click(async () => {
-  $("#para-dataset-banner-image-status").html("");
-  let filePaths = await window.electron.ipcRenderer.invoke("open-file-dialog-import-banner-image");
-  handleSelectedBannerImage(filePaths, "freeform");
-  $("#edit_banner_image_modal").modal("show");
-  $("#edit_banner_image_modal").addClass("show");
-});
-
 // TODO: Dorian -> Simplify the if statement, redundent code
 const uploadBannerImage = async () => {
   $("#para-dataset-banner-image-status").html("Please wait...");
@@ -2034,7 +2025,7 @@ const uploadBannerImage = async () => {
         });
 
         // run the pre-publishing checklist validation -- this is displayed in the pre-publishing section
-        window.showPrePublishingStatus();
+        // window.showPrePublishingStatus();
       } catch (error) {
         clientError(error);
         let emessage = userErrorMessage(error);

src/renderer/src/scripts/others/renderer.js

@@ -5085,6 +5085,7 @@ window.handleSelectedBannerImage = async (path, curationMode) => {
         Swal.close();
       }
     } else {
+      console.log("In this workflow");
       imgHolder.style.display = "none";
       imgContainer.style.display = "block";
 

src/renderer/src/sections/manage_datasets/manage_datasets.html

@@ -1644,19 +1644,7 @@ <h2>Manage Datasets - Upload a banner image</h2>
                   min-width: 450px;
                 "
               >
-                <div id="div-current-banner-img" style="color: black">
-                  <p
-                    style="text-align: center; height: 2em; margin: auto"
-                    id="para-current-banner-img"
-                  >
-                    None
-                  </p>
-                  <div
-                    id="banner_image_loader"
-                    class="ui active green inline loader medium"
-                    style="display: none; margin-left: 46%"
-                  ></div>
-                  <img id="current-banner-img" />
+                
                 </div>
               </div>
             </div>
@@ -1696,7 +1684,6 @@ <h2>Manage Datasets - Upload a banner image</h2>
     <!-- Modal -->
     <div
       class="modal fade"
-      id="edit_banner_image_modal"
       tabindex="-1"
       role="dialog"
       data-backdrop="false"
@@ -1727,25 +1714,23 @@ <h4 class="modal-title" id="edit_banner_image_title">
           </div>
           <div class="modal-body">
             <div id="div-editbanner-img" style="display: flex; flex-direction: row">
-              <div id="div-img-container-holder" class="img-container">
+              <div  class="img-container">
                 Imported image will be shown here. <br />You will be able to crop it before
                 uploading.
               </div>
 
               <div
-                id="div-img-container"
                 class="img-container"
                 style="display: none; flex-direction: column"
               >
-                <img id="image-banner" class="banner-img" width="100%" />
+                <img class="banner-img" width="100%" />
                 <p
-                  id="para-path-image"
+                 
                   style="margin-top: 0.5em; text-align: center; display: none"
                 ></p>
               </div>
             </div>
             <p
-              id="para-dataset-banner-image-status"
               style="
                 text-align: center;
                 font-weight: 400;
@@ -1766,7 +1751,6 @@ <h4 class="modal-title" id="edit_banner_image_title">
                 "
               >
                 <button
-                  id="button-import-banner-image"
                   type="button"
                   class="btn btn-primary"
                   style="border-radius: 4px"
@@ -1785,7 +1769,6 @@ <h4 class="modal-title" id="edit_banner_image_title">
               <input
                 class="banner-image-size input"
                 style="width: 70px; text-align: center; pointer-events: none"
-                id="form-banner-height"
                 type="text"
                 readonly="readonly"
                 size="7"
@@ -1796,7 +1779,6 @@ <h4 class="modal-title" id="edit_banner_image_title">
             </div>
 
             <button
-              id="save-banner-image"
               type="button"
               class="btn btn-primary"
               style="border-radius: 4px; visibility: hidden"