onError, onLoading are discarded

[jonmountjoy]

Hello!

I'm having a problem getting everything working, but for now I suspect that the onError and onLoading are not working here.

For example, the code of various factory methods looks something like this:

factory GoogleVisionImageBuilder.documentTextDetection({
    Key? key,
    required FutureOr<GoogleVision> googleVision,
    required ImageProvider imageProvider,
    required Widget Function(
      BuildContext,
      FullTextAnnotation?,
    ) builder,
    Widget Function(Object)? onError,
    Widget Function()? onLoading,
    int maxResults = 10,
  }) =>
      GoogleVisionImageBuilder(
        builder: (
          BuildContext context,
          AsyncSnapshot<BatchAnnotateImagesResponse> snapshot,
        ) =>
            builder(
          context,
          snapshot.data?.responses.first.fullTextAnnotation,
        ),
        imageProvider: imageProvider,
        googleVision: googleVision,
        features: GoogleVisionBuilderBase.getFeatures(
            AnnotationType.documentTextDetection, maxResults),
      );

Which looks like it just discards both the onError and onLoading arguments?

I wonder if it should instead be (here, and in all the other variations),

factory GoogleVisionImageBuilder.documentTextDetection({
    Key? key,
    required FutureOr<GoogleVision> googleVision,
    required ImageProvider imageProvider,
    required Widget Function(
      BuildContext,
      FullTextAnnotation?,
    ) builder,
    Widget Function(Object)? onError,
    Widget Function()? onLoading,
    int maxResults = 10,
  }) =>
      GoogleVisionImageBuilder(
        onError: onError,                               /*.  NEW */
        onLoading: onLoading,                  /*.  NEW */
        builder: (
          BuildContext context,
          AsyncSnapshot<BatchAnnotateImagesResponse> snapshot,
        ) =>
            builder(
          context,
          snapshot.data?.responses.first.fullTextAnnotation,
        ),
        imageProvider: imageProvider,
        googleVision: googleVision,
        features: GoogleVisionBuilderBase.getFeatures(
            AnnotationType.documentTextDetection, maxResults),
      );

PS. I couldn't get a local version to work as I'm not familiar with Melos and you have a dependence on collections: 1.19.1 which seems really high and higher than the default 1.18.0 which is pinned to Flutter 3.24.5 which is the latest stable?