From 327bb477b2b7874be6a3f18771be26daef803ddc Mon Sep 17 00:00:00 2001 From: mguleryuz Date: Wed, 17 Sep 2025 13:49:58 -0500 Subject: [PATCH 1/3] chore: update package.json and tsconfig files for better esm and cjs handling --- packages/miniapp-node/package.json | 14 ++++++++++---- packages/miniapp-node/tsconfig.json | 6 ++++-- packages/miniapp-node/tsconfig.node.json | 6 +++--- 3 files changed, 17 insertions(+), 9 deletions(-) diff --git a/packages/miniapp-node/package.json b/packages/miniapp-node/package.json index e8adddd2..59a383a0 100644 --- a/packages/miniapp-node/package.json +++ b/packages/miniapp-node/package.json @@ -7,14 +7,21 @@ "url": "https://github.com/farcasterxyz/frames.git", "directory": "packages/miniapp-node" }, - "main": "dist/index.js", - "module": "esm/index.js", + "exports": { + ".": { + "types": "./dist/types/index.d.ts", + "import": "./dist/esm/index.js", + "require": "./dist/cjs/index.js", + "default": "./dist/cjs/index.js" + } + }, "scripts": { "clean": "rm -rf dist esm", "prebuild": "npm run clean", - "build": "pnpm build:cjs & pnpm build:esm", + "build": "pnpm build:cjs & pnpm build:esm & pnpm build:types", "build:cjs": "tsc -p tsconfig.node.json", "build:esm": "tsc -p tsconfig.json", + "build:types": "tsc -p tsconfig.json --declaration --emitDeclarationOnly --outDir dist/types", "typecheck": "tsc --noEmit", "test": "vitest run", "test:watch": "vitest", @@ -22,7 +29,6 @@ }, "files": [ "dist", - "esm", "src" ], "devDependencies": { diff --git a/packages/miniapp-node/tsconfig.json b/packages/miniapp-node/tsconfig.json index c2c59a61..c6e24b8d 100644 --- a/packages/miniapp-node/tsconfig.json +++ b/packages/miniapp-node/tsconfig.json @@ -1,8 +1,10 @@ { "extends": "@farcaster/tsconfig/browser.json", "include": ["src"], - "exclude": ["esm", "dist", "build", "node_modules"], + "exclude": ["dist", "build", "node_modules"], "compilerOptions": { - "outDir": "esm" + "outDir": "dist/esm", + "declaration": false, + "tsBuildInfoFile": "./tsconfig.tsbuildinfo" } } diff --git a/packages/miniapp-node/tsconfig.node.json b/packages/miniapp-node/tsconfig.node.json index f9240e5e..0d2039e4 100644 --- a/packages/miniapp-node/tsconfig.node.json +++ b/packages/miniapp-node/tsconfig.node.json @@ -1,9 +1,9 @@ { "extends": "@farcaster/tsconfig/node.json", "include": ["src"], - "exclude": ["esm", "dist", "build", "node_modules"], + "exclude": ["dist", "build", "node_modules"], "compilerOptions": { - "outDir": "dist" + "outDir": "dist/cjs", + "declaration": false } } - From 2e6e1a2c41b143be884abb87579b666a6f410e43 Mon Sep 17 00:00:00 2001 From: mguleryuz Date: Wed, 17 Sep 2025 14:48:31 -0500 Subject: [PATCH 2/3] chore: reorder build scripts in package.json and update outputs in turbo.json --- packages/miniapp-node/package.json | 2 +- packages/miniapp-node/turbo.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/miniapp-node/package.json b/packages/miniapp-node/package.json index 59a383a0..5ab56154 100644 --- a/packages/miniapp-node/package.json +++ b/packages/miniapp-node/package.json @@ -18,7 +18,7 @@ "scripts": { "clean": "rm -rf dist esm", "prebuild": "npm run clean", - "build": "pnpm build:cjs & pnpm build:esm & pnpm build:types", + "build": "pnpm build:types && pnpm build:cjs && pnpm build:esm", "build:cjs": "tsc -p tsconfig.node.json", "build:esm": "tsc -p tsconfig.json", "build:types": "tsc -p tsconfig.json --declaration --emitDeclarationOnly --outDir dist/types", diff --git a/packages/miniapp-node/turbo.json b/packages/miniapp-node/turbo.json index 4857172f..11c44c96 100644 --- a/packages/miniapp-node/turbo.json +++ b/packages/miniapp-node/turbo.json @@ -2,7 +2,7 @@ "extends": ["//"], "tasks": { "build": { - "outputs": [".dist/**", "esm/**"] + "outputs": [".dist/**"] } } } From 226902dd3c899f3d8b1c6d56311d7480c3dec89e Mon Sep 17 00:00:00 2001 From: mguleryuz Date: Wed, 17 Sep 2025 15:03:26 -0500 Subject: [PATCH 3/3] chore: simplify package.json by removing exports and defining main, module, and types directly --- packages/miniapp-node/package.json | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/packages/miniapp-node/package.json b/packages/miniapp-node/package.json index 5ab56154..b171f947 100644 --- a/packages/miniapp-node/package.json +++ b/packages/miniapp-node/package.json @@ -7,14 +7,9 @@ "url": "https://github.com/farcasterxyz/frames.git", "directory": "packages/miniapp-node" }, - "exports": { - ".": { - "types": "./dist/types/index.d.ts", - "import": "./dist/esm/index.js", - "require": "./dist/cjs/index.js", - "default": "./dist/cjs/index.js" - } - }, + "main": "./dist/cjs/index.js", + "module": "./dist/esm/index.js", + "types": "./dist/types/index.d.ts", "scripts": { "clean": "rm -rf dist esm", "prebuild": "npm run clean",