Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close callback called too early #200

Closed
peter-vasarhelyi opened this issue Dec 10, 2021 · 2 comments
Closed

Close callback called too early #200

peter-vasarhelyi opened this issue Dec 10, 2021 · 2 comments

Comments

@peter-vasarhelyi
Copy link
Contributor

Hello!

When I call the Session.close method with a callback, I think it is called too early (immediately). I believe the bug lies here: https://github.com/farhadi/node-smpp/blob/master/lib/smpp.js#L237
When I negate the condition it works properly. The same applies to the destroy function
@peter-vasarhelyi peter-vasarhelyi mentioned this issue Dec 10, 2021
Merged
@ajamous
Copy link

ajamous commented Feb 3, 2022

Thanks @peter-vasarhelyi , do you think this can lead to #205 ?

@juliangut
Copy link
Collaborator

The PR has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juliangut @peter-vasarhelyi @ajamous