feat: impl std::error::Error for Frame#29
Conversation
|
Seems not possible to override and proxy the |
anyhow does the same--disallowing downcast once boxed into a |
2d5a155 to
f407f57
Compare
87b1908 to
148952e
Compare
Based on our API, one can first downcast the Error to Frame and then call Frame::error to fetch the internal error and call downcast on that error instead? |
tisonkun
left a comment
There was a problem hiding this comment.
Generally LGTM
We may considere how to introduce the concept of Frame to users.
Exn is the final interface and Frame wraps the inner error that users can do some advanced interaction; see examples?
Yes. |
|
Perhaps add a changelog entry? |
|
@andylokandy What if we release a 0.3.0 and handle other issues later? |
This refers to #20