refactor(index): change default methods to cors-safelisted methods
#359
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climba03003
requested changes
Feb 19, 2025
index.js
Outdated
| @@ -8,7 +8,7 @@ const { | |||
|
|
|||
| const defaultOptions = { | |||
| origin: '*', | |||
| methods: 'GET,HEAD,PUT,PATCH,POST,DELETE', | |||
| methods: 'GET,HEAD,PUT', | |||
There was a problem hiding this comment.
From your reference, it should be GET, HEAD and POST. Instead of PUT.
There was a problem hiding this comment.
Whoops, thanks @climba03003, fixed in 32c895b
climba03003
approved these changes
Feb 19, 2025
| @@ -63,7 +63,7 @@ You can use it as is without passing any option or you can configure it as expla | |||
| cb(new Error("Not allowed"), false) | |||
| } | |||
| ``` | |||
| * `methods`: Configures the **Access-Control-Allow-Methods** CORS header. Expects a comma-delimited string (e.g., 'GET,PUT,POST') or an array (e.g., `['GET', 'PUT', 'POST']`). Default: `GET,HEAD,PUT,PATCH,POST,DELETE`. | |||
| * `methods`: Configures the **Access-Control-Allow-Methods** CORS header. Expects a comma-delimited string (e.g., 'GET,PUT,POST') or an array (e.g., `['GET', 'PUT', 'POST']`). Default: `GET,HEAD,PUT`. | |||
There was a problem hiding this comment.
Shouldn't we add some explanations and a link to the specification?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #358.
This is a breaking change and will require a semver major release.
Checklist
npm run testandnpm run benchmarkand the Code of conduct