Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in 2.8 #28

Closed
benbovy opened this issue Oct 12, 2019 · 4 comments · Fixed by #29
Closed

Regression in 2.8 #28

benbovy opened this issue Oct 12, 2019 · 4 comments · Fixed by #29

Comments

@benbovy
Copy link
Member

benbovy commented Oct 12, 2019

There might be an issue introduced between versions 2.7 and 2.8.

Taking the example in the notebook FastScape_test included in the examples, plotting the topography after half the total simulation time,

The results for version 2.7 and 2.8 in MacOS, and 2.7 in Linux:

ok

And the results for version 2.8 in Linux:

ko

The model doesn't crash, but it seems that SPL sediment transport is not working properly, only for Linux and version 2.8.

This is weird! Maybe it has something to do with how the Python bindings are compiled with F2PY. I haven't checked the output from Fortran examples in Linux, though. Maybe related to fastscape-lem/fastscape#7.

Any idea @jeanbraun ?
@benbovy
Copy link
Member Author

benbovy commented Oct 12, 2019

I have the same issue when running the Fan.f90 example, so it does not seem to be related to Python bindings only.

@benbovy
Copy link
Member Author

benbovy commented Oct 12, 2019

Regression has been introduced in #23.

@benbovy
Copy link
Member Author

benbovy commented Oct 12, 2019

So the reason seems to be that call set_bc is missing in StreamPowerLaw routines (bc is allocated but not set properly). Or better would be to add bc in context to avoid unnecessarily calling set_bc multiple times.

@benbovy
Copy link
Member Author

benbovy commented Oct 12, 2019

Also, hwater should not be deallocated in StreamPowerLawSingleFlowDirection.

@benbovy benbovy mentioned this issue Oct 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix boundary conditions in stream power law fastscape-lem/fastscapelib-fortran
1 participant
@benbovy