Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configurable max number of iterations in SPL and marine solvers #40

Open
benbovy opened this issue Oct 9, 2020 · 0 comments
Open

Allow configurable max number of iterations in SPL and marine solvers #40

benbovy opened this issue Oct 9, 2020 · 0 comments

Comments

@benbovy
Copy link
Member

benbovy commented Oct 9, 2020

(reported by Rob Moucha)

Currently this maximum number of iterations is hard-coded and cause the solver to stop (SPL), or the whole program to stop (marine):

fastscapelib-fortran/src/StreamPowerLaw.f90

Line 53 in d009dbf

do while (err.gt.tol.and.nGSStreamPowerLaw.lt.99)

fastscapelib-fortran/src/Marine.f90

Line 485 in 28c6afc

if (niter.gt.1000) then

Users should be able to configure this. We could also allow no limit at all (e.g., a value of -1).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benbovy