Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is compaction turned off? #58

Open
rbrtmch opened this issue Nov 3, 2023 · 1 comment
Open

Is compaction turned off? #58

rbrtmch opened this issue Nov 3, 2023 · 1 comment

Comments

@rbrtmch
Copy link

rbrtmch commented Nov 3, 2023

I noticed that the call to the compaction routine is commented out. Is it turned off or is in done somewhere else?

fastscapelib-fortran/src/Marine.f90

Line 141 in b4d13f4

!call compaction (F1,F2,poro1,poro2,zporo1,zporo2,nn,dh,zi,zo)

@benbovy
Copy link
Member

benbovy commented Nov 4, 2023

Looks like it has always been commented out since the addition of the marine component in #20. Not sure if that is intentional or not, though. @jeanbraun and Xiaoping Yuan might have a better idea as I just included their code in that PR and I'm not very familiar with the internals of the marine component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benbovy @rbrtmch