You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
simplify the structure (no need of fixtures if it's just for the input parameters of a single test).
test the actual logic implemented in compute_orographic_precip. Is there any ideal topography where we can compare the result against an analytical solution (e.g., with a gaussian pulse like shown in README)? Probably worth checking the paper.
add tests for the two process classes in fastscape_ext. Testing OrographicPrecipitation could be very similar than the test for compute_orographic_precip. No need to test the whole logic of OrographicDrainageDischarge (its base class will be tested upstream in fastscape), just ensure that values are converted as expected.
The text was updated successfully, but these errors were encountered:
TODO:
compute_orographic_precip
. Is there any ideal topography where we can compare the result against an analytical solution (e.g., with a gaussian pulse like shown in README)? Probably worth checking the paper.fastscape_ext
. TestingOrographicPrecipitation
could be very similar than the test forcompute_orographic_precip
. No need to test the whole logic ofOrographicDrainageDischarge
(its base class will be tested upstream in fastscape), just ensure that values are converted as expected.The text was updated successfully, but these errors were encountered: