Custom service method causing typebox issue

[laurensiusadi]

So I made a custom service method called save inside ProductService, which is basically patch or create.
I'm using Feathers v5.0.0 with koa and Typebox.

export class ProductService<ServiceParams extends Params = ProductParams> extends KnexService<
  Product,
  ProductData,
  ProductParams,
  ProductPatch
> {
  async save(data: Product) {
    try {
      const [record] = await this.find({ query: { id: data.id }, paginate: false })
      if (record) {
        this.patch(data.id, data)
      } else {
        this.create(data)
      }
    } catch (error: any) {
      console.log('Error saving product: ', error)
    }
  }
}

It's causing this error when the save method is called from another service

TypeError: Cannot convert undefined or null to object
    at Function.keys (<anonymous>)    at resolveAndGetDispatch (\node_modules\@feathersjs\schema\src\hooks\resolve.ts:160:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async ProductService.<anonymous> (\node_modules\@feathersjs\schema\src\hooks\resolve.ts:169:22)    at async ProductService.logError (\src\hooks\log-error.ts:7:5)
    at async Object.create (\src\services\webhooks\webhooks.ts:24:9)
    at async Object.logError (\src\hooks\log-error.ts:7:5)
    at async \node_modules\@feathersjs\koa\src\rest.ts:36:21    at async bodyParser (\node_modules\koa-bodyparser\index.js:95:5)
    at async \node_modules\@feathersjs\koa\src\handlers.ts:6:5

  app.use('/webhooks/products/update', {
    async create(data: Product) {
      try {
        await app.service(productPath).save(data)
      } catch (error: any) {
        console.log('Error', error)
      }
    }
  })

But it's not causing the error when not using save method

  app.use('/webhooks/products/update', {
    async create(data: Product) {
      try {
        const [record] = await app.service(productPath).find({ query: { id: data.id }, paginate: false })
        if (record) {
          app.service(productPath).patch(data.id, data)
        } else {
          app.service(productPath).create(data)
        }
      } catch (error: any) {
        console.log('Error', error)
      }
    }
  })

Also added

export const productMethods = ['find', 'get', 'create', 'patch', 'remove', 'save'] as const

What's am I missing here? Thanks.

[daffl]

The method should return something. This will probably work:

export class ProductService<ServiceParams extends Params = ProductParams> extends KnexService<
  Product,
  ProductData,
  ProductParams,
  ProductPatch
> {
  async save(data: Product) {
    try {
      const [record] = await this.find({ query: { id: data.id }, paginate: false })
      if (record) {
        return this.patch(data.id, data)
      } else {
        return this.create(data)
      }
    } catch (error: any) {
      console.log('Error saving product: ', error)
    }
  }
}

[laurensiusadi]

Wow that works. Thanks!