redirect/query/headers not set in session if oauth override url used. Bug?

[tjenkinson]

Hey,

I noticed here

feathers/packages/authentication-oauth/src/service.ts

Lines 161 to 168 in c619ab2

	if (feathers_token) {
	debug('Got feathers_token query parameter to link accounts', feathers_token)
	session.accessToken = feathers_token
	}
	session.redirect = redirect
	session.query = restQuery
	session.headers = headers

some properties are set on .session and used later.

but they are missing from get()

feathers/packages/authentication-oauth/src/service.ts

Lines 173 to 181 in c619ab2

	async get(override: string, params: OAuthParams) {
	const result = await this.handler('GET', params, {}, override)
	if (override === 'callback') {
	return this.authenticate(params, result)
	}
	return result
	}

which is used for overrides in the config.

Shouldn't this endpoint also be setting those things in the session?

[daffl]

Hm, this might require some additional testing. I'd assume it should only do that when the override is not callback?