link to github being interpertated like a user

[wakest]

looking at this post from Phanpy logged in to Mastodon, when I click the link you have to Github, Phanpy errors "Unable to load account."
I assume it has something to do with your link starting with an @ so unsure if this is actually a Phanpy bug, but figured I would file it here first.

cc @cheeaun

[dahlia]

I think it's a bug due to Phanpy's heuristics to detect mentions? @cheeaun Am I right?

[cheeaun]

There's no mention detection heuristics. Phanpy assumes all at-mentions point to profile pages. Clicking it performs https://mastodon.social/api/v1/accounts/lookup?acct=https%3A%2F%2Fgithub.com%2Ffedify-dev%2Fmarkdown-it-mention that will lookup if the profile is there, else show "Unable to load account" error.

Some clients handle this differently. Here's Ivory:

Some clients are smarter, they auto-fallback to the browser/webview immediately (Ice Cubes, Mona).

For Phanpy's case, as it's a web app, the click event on the link can't "fallback" anymore after intercepting it — browsers block opening new tab/window if it's not initiated within a period of time.

A different approach is to "preload" the links (scan all links, check if the account links work, then immediately mark them as fallback) before they're clicked — but this uses up API calls without clicking anything.

[dahlia]

Phanpy assumes all at-mentions point to profile pages.

@cheeaun Does it mean that any <a> elements start with @ are treated as mentions?

[cheeaun]

@dahlia yeah… kinda, though slightly complicated due to different platforms mark them differently…

Reference: https://github.com/cheeaun/phanpy/blob/0759e6431f4572a1d0f10b8eeda0b46b9f14bc0b/src/utils/handle-content-links.js#L19-L22

((target.classList.contains('u-url') ||
    target.classList.contains('mention')) &&
    textStartsWithAt) ||
(textBeforeLinkIsAt && !textStartsWithAt)

[dahlia]

It's strange that the problematic link in the post doesn't seem to meet the condition: 🤔

<a href="https://github.com/fedify-dev/markdown-it-mention">@fedify/markdown-it-mention</a>

[cheeaun]

@dahlia oh, this /^@[^@]+(@[^@]+)?$/ regex is used to add 'mention' class to the link 🙈 https://github.com/cheeaun/phanpy/blob/0759e6431f4572a1d0f10b8eeda0b46b9f14bc0b/src/utils/enhance-content.js#L92-L107

[dahlia]

@cheeaun Oh, okay.

@wakest I believe this cannot be easily fixed, and irrelevant to Fedify, so … closing this.