Ludo Game Die can be rolled even after it is a player's turn to move

[botwhytho]

In the video below, one can see two instances where the game label says 'Player A to move' but one can continue rolling the dice. The game state actually respects the first die roll and when the player moves the piece it uses that but it is confusing to be able to continue rolling the dice. BlDoubleClickEvent event handler should be temporarily removed while a player makes a move and added back right after.

LudoDieBug2.mp4

[botwhytho]

PR Created feenkcom/gtoolkit-demos#16

[onierstrasz]

Haha! Thanks. I'll have a look ...

[onierstrasz]

In the proposed solution, there is a lot of logic added to GtLudoGameElement>>#initializeFor:. A cleaner solution would be to have the GtLudoDieElement hold a reference to the game instead of the die (or instead of just the die), and then ask the game to roll the die. The game will then know if the die can be rolled. This would also require the initialization of the DieELement to be changed in GtLudoBoardElement>>#addDieElement. In this way we would keep game logic out of the UI elements.

[onierstrasz]

Summary of new changes:

• Add GtLudoGame>>#rollDie to roll the die only if self playerToRoll
• Add GtLudoGame>>#rollDie: for testing purposes to take an explicit die value
• Add GtLudoGameExamples>>#playerArollsTwice to test this scenario:

example := GtLudoGameExamples new.
game := example playerAentersTokenA.
game rollDie: 4.
example assert: game die topFace equals: 4.
game rollDie: 5.
example assert: game die topFace equals: 4.
game

• Refactor GtLudoDieElement to evaluate a stored doubleClickAction which is initialized to [ self die roll ]
• Update GtLudoBoardElement>>#addDieElement to changed the doubleClickAction to [ self game rollDie ], which performs the necessary check.