Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LeDatabaseClassStore recompiles pages unnecessarily #4285

Open
akgrant43 opened this issue Jan 24, 2025 · 0 comments
Open

LeDatabaseClassStore recompiles pages unnecessarily #4285

akgrant43 opened this issue Jan 24, 2025 · 0 comments
Assignees
@akgrant43

Comments

@akgrant43
Copy link
Contributor

Currently updating a lepiter page in a class store by modifying its method incorrectly causes the page to be recompiled.

This typically happens when recovering changes, e.g. using Epicea.

The double compilation is triggered because the method modification (compilation) causes the page to be reloaded, which then announces the change, which then recompiles the method.
@akgrant43 akgrant43 self-assigned this Jan 24, 2025
akgrant43 added a commit to feenkcom/lepiter that referenced this issue Jan 24, 2025
@akgrant43
[feenkcom/gtoolkit#4285] Class Store: don't recompile pages that were…
fafe720 
… modfied by changing the store method.
syrel pushed a commit that referenced this issue Jan 24, 2025
Release version v1.0.1471
fa94b8f 
Metacello new
    baseline: 'GToolkitForPharo9';
    repository: 'github://feenkcom/gtoolkit:v1.0.1471/src';
    load

All commits (including upstream repositories) since last build:
feenkcom/gt4pharo@4fe7da by Alistair Grant
Remove RGBehavior>>asEpiceaRingDefinition


feenkcom/lepiter@fafe72 by Alistair Grant
[#4285] Class Store: don't recompile pages that were modfied by changing the store method.
chisandrei added a commit to feenkcom/lepiter that referenced this issue Jan 27, 2025
@chisandrei
[feenkcom/gtoolkit#4285] Class Store: don't recompile pages that were…
33012e2 
… modfied by changing the store method - part2
syrel pushed a commit that referenced this issue Jan 28, 2025
Release version v1.0.1479
498f421 
Metacello new
    baseline: 'GToolkitForPharo9';
    repository: 'github://feenkcom/gtoolkit:v1.0.1479/src';
    load

All commits (including upstream repositories) since last build:
feenkcom/lepiter@33012e by Andrei Chi�
[#4285] Class Store: don't recompile pages that were modfied by changing the store method - part2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akgrant43 akgrant43

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akgrant43