Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP error detection #49

Open
lperrinfano opened this issue Oct 25, 2012 · 0 comments
Open

HTTP error detection #49

lperrinfano opened this issue Oct 25, 2012 · 0 comments

Comments

@lperrinfano
Copy link

The code (near line 232) that detects CouchDB HTTP errors seems dangerous to me:

          if ('error' in json) {
            cbFired = true;
            return cb && cb(json);
          }

If I save a document with an 'error' attribute, node-couchdb will raise an error every time I fetch it. You should rely on the HTTP status code instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant