Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it not applicable for v1.12.0? #25

Closed
yoshida-git-ai opened this issue Oct 17, 2023 · 3 comments
Closed

Is it not applicable for v1.12.0? #25

yoshida-git-ai opened this issue Oct 17, 2023 · 3 comments
Labels
question Further information is requested

Comments

@yoshida-git-ai
Copy link

I'm using a clean theme
Is it not applicable for v1.12.0?

@felixhahnweilheim
Copy link
Owner

Hi @yoshida-git-ai
I have developped this module for HumHub version 1.15.
So I haven't tested it with older versions and can’t say if it works.

@felixhahnweilheim felixhahnweilheim added the question Further information is requested label Oct 25, 2023
@ArchBlood
Copy link

If the module uses or extends classes that were introduced in v1.15 then this module wouldn't be usable in any older versions of HumHub and a compatibility check would have to be implemented if reverse compatibility were to be implemented.

@felixhahnweilheim
Copy link
Owner

Yes, and in this case also the stylesheets should be tested. Espacially because an older HumHub version also means there are some older modules.

If you really need backwards compatibility, you can

  • test it at your own risk and create a PR
  • ask me to do it as a paid service.

@felixhahnweilheim felixhahnweilheim closed this as not planned Won't fix, can't repro, duplicate, stale Nov 20, 2023
@felixhahnweilheim felixhahnweilheim pinned this issue Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants