Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how strict to control which headers runtimes are permitted to return #3

Open
rylev opened this issue Jun 14, 2024 · 1 comment

Comments

@rylev
Copy link
Collaborator

rylev commented Jun 14, 2024

The current status quo in the conformance tests is to exhaustively check headers erroring if a header is set when the test does not specify that it can be. The tests have some flexibility in that they can specify the following:

  • A header is set but it doesn't matter what the value is
  • A header can be set but if its missing it's fine
  • A header must be set and its value equal to what is specified.

It is likely that for some tests, we'll want to be strict about some headers, but for many other tests we don't really care.

@lann
Copy link
Contributor

lann commented Jun 14, 2024

This is just a theoretical problem until we run into actual issues, but there are a bunch of HTTP semantic equivalences that strict header checking wouldn't allow for; off the top of my head:

  • Different transfer-encoding of the same body (unless a particular test is checking that explicitly!)
  • Header value merging
  • Case insensitivity for certain header values (media types)

Additionally, we should decide how strict we want "conformance" to be about extra headers like distributed tracing IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants