Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local: lookup for bindle-server uses amd64 build if os=linux #131

Open
vdice opened this issue Sep 18, 2023 · 0 comments
Open

Local: lookup for bindle-server uses amd64 build if os=linux #131

vdice opened this issue Sep 18, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@vdice
Copy link
Member

vdice commented Sep 18, 2023

For the local installer scenario, the lookup method for fetching the bindle-server binary grabs the checked-in linux/amd64 build when the os is linux:

source = lookup({
linux="https://raw.githubusercontent.com/fermyon/installer/93008bc6461076da5c5f7f99cffc3e68b1955a17/local/bindle/bindle-server"
}, var.os, "https://bindle.blob.core.windows.net/releases/bindle-v0.8.0-${var.os}-${var.arch}.tar.gz")

This causes errors for linux/aarch64 environments.

Update the lookup to also inspect arch.

Note that linux/aarch64 binaries are only available as of bindle v0.8.2, so we would have to bump the version in tandem.

@vdice vdice added the bug Something isn't working label Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant