Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): add auth for hippo/bindle #4

Closed
wants to merge 4 commits into from
Closed

feat(*): add auth for hippo/bindle #4

wants to merge 4 commits into from

Conversation

vdice
Copy link
Member

@vdice vdice commented May 24, 2022

  • adds Traefik basic auth middleware to both Bindle
  • configures admin auth for Hippo

Closes #3

Requires #1.

Commit with changes apart from #1 in 8c4115280b61460323bc7c710714bbebc1b51bcd

@vdice
Copy link
Member Author

vdice commented May 24, 2022

We may want to only add this to Bindle for this PR for 2 reasons:

  1. hippo-cli and spin would need added functionality to add basic auth un/pw values for requests to hippo
  2. @bacongobbler thinks the 'pre-seeded master acccount' work in Hippo should be fairly straightforward and able to be worked on soon.

@vdice vdice marked this pull request as ready for review May 25, 2022 16:37
@vdice vdice changed the title Feat/traefik basic auth feat(*): add traefik basic auth for hippo/bindle May 25, 2022
@bacongobbler
Copy link
Member

bacongobbler commented May 25, 2022

ACK on 2. I should have the PR up by EOD - just writing some tests at this point

@bacongobbler
Copy link
Member

deislabs/hippo#814

@vdice
Copy link
Member Author

vdice commented May 25, 2022

Nice, thanks for the link @bacongobbler

I think I can tell from #814 how to set the un/pw values -- but how to set registration mode to AdminOnly?

        # Registration configuration
        Hippo__Administrators__Username = var.admin_account_username
        Hippo__Administrators__Password = var.admin_account_password

@bacongobbler
Copy link
Member

Hippo__RegistrationMode = var.administration_mode oughta do it. The accepted values are "Closed", "Open" (default), and "AdministratorOnly".

@bacongobbler
Copy link
Member

bacongobbler commented May 25, 2022

I think you may have to use the following to set the uname/pwd:

Hippo__Administrators__0__Username = var.admin_account_username
Hippo__Administrators__0__Password = var.admin_account_password

Because it accepts a list of user credentials... Let me see if .NET's documentation says anything about this

@bacongobbler
Copy link
Member

Yep: https://stackoverflow.com/a/37657321

@vdice vdice marked this pull request as draft May 25, 2022 22:35
@vdice
Copy link
Member Author

vdice commented May 25, 2022

(Back into draft while we add auth for Hippo via its own registration mode/config)

@vdice
Copy link
Member Author

vdice commented May 26, 2022

We should be able to test this once we have a new Hippo rc we can fetch cc @bacongobbler

@vdice vdice changed the title feat(*): add traefik basic auth for hippo/bindle feat(*): add auth for hippo/bindle May 26, 2022
@vdice
Copy link
Member Author

vdice commented May 27, 2022

Closing this PR which attempted to tackle both bindle and Hippo auth in one go. However, Hippo isn't yet in a state to support bindle auth e2e yet. First PR focusing just on Hippo auth is: #8

@vdice vdice closed this May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fermyon Platform Authz approach for Quick-Start
2 participants