Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dark mode] improve color contrast for code #23

Open
flynnduism opened this issue Apr 6, 2022 · 0 comments
Open

[dark mode] improve color contrast for code #23

flynnduism opened this issue Apr 6, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@flynnduism
Copy link
Member

flynnduism commented Apr 6, 2022 •
edited
Loading

The baseline color used by the current highlight.js theme is a medium gray, used for inline comments:

Screen Shot 2022-04-06 at 8 51 51 AM

This grey is not sufficient for color contrast guidelines - it's not legible enough.

Screen Shot 2022-04-06 at 8 53 55 AM
@flynnduism flynnduism added the bug Something isn't working label Apr 6, 2022
flynnduism added a commit to flynnduism/styleguide that referenced this issue May 29, 2022
@flynnduism
dark mode adjustments
c0ee084 
* set scrollbar background color browser override (fermyon#24)
* improve color contrast for code blocks (fermyon#23)

Signed-off-by: flynnduism <[email protected]>
@flynnduism flynnduism mentioned this issue May 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@flynnduism