From ead49388c62bf2dd81e96e5eb73d82d3edcba352 Mon Sep 17 00:00:00 2001 From: dsinghvi Date: Mon, 30 Sep 2024 00:43:09 -0400 Subject: [PATCH] fix --- .../cli/docs-importers/commons/package.json | 4 ++-- .../commons/src/FernDocsBuilderImpl.ts | 20 ++++++------------- .../mintlify/src/convertMarkdown.ts | 1 + 3 files changed, 9 insertions(+), 16 deletions(-) diff --git a/packages/cli/docs-importers/commons/package.json b/packages/cli/docs-importers/commons/package.json index 50c85bb75b..06e5f80555 100644 --- a/packages/cli/docs-importers/commons/package.json +++ b/packages/cli/docs-importers/commons/package.json @@ -18,8 +18,8 @@ "scripts": { "clean": "rm -rf ./lib && tsc --build --clean", "compile": "tsc --build", - "test": "vitest --run", - "test:update": "vitest --run -u", + "test": "vitest --passWithNoTests --run", + "test:update": "vitest --passWithNoTests --run -u", "lint:eslint": "eslint --max-warnings 0 . --ignore-path=../../../../../.eslintignore", "lint:eslint:fix": "yarn lint:eslint --fix", "format": "prettier --write --ignore-unknown --ignore-path ../../../../../shared/.prettierignore \"**\"", diff --git a/packages/cli/docs-importers/commons/src/FernDocsBuilderImpl.ts b/packages/cli/docs-importers/commons/src/FernDocsBuilderImpl.ts index b93e9a4021..477e6b62ac 100644 --- a/packages/cli/docs-importers/commons/src/FernDocsBuilderImpl.ts +++ b/packages/cli/docs-importers/commons/src/FernDocsBuilderImpl.ts @@ -1,12 +1,4 @@ import { docsYml, DOCS_CONFIGURATION_FILENAME, FERN_DIRECTORY } from "@fern-api/configuration"; -import { - VersionConfig, - VersionFileConfig, - NavbarLink, - LogoConfiguration, - ColorsConfiguration, - LayoutConfig -} from "@fern-api/configuration/lib/docs-yml/schemas"; import { AbsoluteFilePath, dirname, join, RelativeFilePath } from "@fern-api/fs-utils"; import { FernDocsBuilder, FernDocsNavigationBuilder } from "./FernDocsBuilder"; import { mkdir, writeFile, cp } from "fs/promises"; @@ -77,13 +69,13 @@ export class FernDocsBuilderImpl extends FernDocsBuilder { versionConfig, navigation }: { - versionConfig: VersionConfig; - navigation: VersionFileConfig; + versionConfig: docsYml.RawSchemas.VersionConfig; + navigation: docsYml.RawSchemas.VersionFileConfig; }): void { throw new Error("Method not implemented."); } - public addNavbarLink({ link }: { link: NavbarLink }): void { + public addNavbarLink({ link }: { link: docsYml.RawSchemas.NavbarLink }): void { if (this.docsYml.navbarLinks == null) { this.docsYml.navbarLinks = [link]; } @@ -98,15 +90,15 @@ export class FernDocsBuilderImpl extends FernDocsBuilder { this.docsYml.favicon = favicon; } - public setLogo({ logo }: { logo: LogoConfiguration }): void { + public setLogo({ logo }: { logo: docsYml.RawSchemas.LogoConfiguration }): void { this.docsYml.logo = logo; } - public setColors({ colors }: { colors: ColorsConfiguration }): void { + public setColors({ colors }: { colors: docsYml.RawSchemas.ColorsConfiguration }): void { this.docsYml.colors = colors; } - public setLayout({ layout }: { layout: LayoutConfig }): void { + public setLayout({ layout }: { layout: docsYml.RawSchemas.LayoutConfig }): void { this.docsYml.layout = layout; } diff --git a/packages/cli/docs-importers/mintlify/src/convertMarkdown.ts b/packages/cli/docs-importers/mintlify/src/convertMarkdown.ts index 467c287701..3f881c7cfe 100644 --- a/packages/cli/docs-importers/mintlify/src/convertMarkdown.ts +++ b/packages/cli/docs-importers/mintlify/src/convertMarkdown.ts @@ -47,6 +47,7 @@ export async function convertMarkdown({ title: data.title, subtitle: data.description, layout: data.mode != null ? "reference" : undefined, + // eslint-disable-next-line @typescript-eslint/ image: data["og:image"] as any, slug },