Update support for workflow_dispatch
#51
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+104
to
+109
| echo "::warning::No successful run found for 'push' event. Checking for 'workflow_dispatch' event..." | ||
| LAST_SUCCESSFUL_RUN_ID=$(gh run list --status=success --branch="$TARGET_BRANCH" --workflow="$GITHUB_BASELINE_WORKFLOW" --event=workflow_dispatch --json=databaseId --limit=1 -q '.[] | .databaseId') | ||
| fi | ||
|
|
||
| if [ -z "$LAST_SUCCESSFUL_RUN_ID" ]; then | ||
| echo "::error::No successful run found on the target branch for 'push' or 'workflow_dispatch' events." |
There was a problem hiding this comment.
If we could add more events, can we also check for schedule events? Ran into this issue as well. Thanks!
Suggested change
| echo "::warning::No successful run found for 'push' event. Checking for 'workflow_dispatch' event..." | |
| LAST_SUCCESSFUL_RUN_ID=$(gh run list --status=success --branch="$TARGET_BRANCH" --workflow="$GITHUB_BASELINE_WORKFLOW" --event=workflow_dispatch --json=databaseId --limit=1 -q '.[] | .databaseId') | |
| fi | |
| if [ -z "$LAST_SUCCESSFUL_RUN_ID" ]; then | |
| echo "::error::No successful run found on the target branch for 'push' or 'workflow_dispatch' events." | |
| echo "::warning::No successful run found for 'push' event. Checking for 'workflow_dispatch' event..." | |
| LAST_SUCCESSFUL_RUN_ID=$(gh run list --status=success --branch="$TARGET_BRANCH" --workflow="$GITHUB_BASELINE_WORKFLOW" --event=workflow_dispatch --json=databaseId --limit=1 -q '.[] | .databaseId') | |
| fi | |
| if [ -z "$LAST_SUCCESSFUL_RUN_ID" ]; then | |
| echo "::warning::No successful run found for 'workflow_dispatch' event. Checking for 'schedule' event..." | |
| LAST_SUCCESSFUL_RUN_ID=$(gh run list --status=success --branch="$TARGET_BRANCH" --workflow="$GITHUB_BASELINE_WORKFLOW" --event=schedule --json=databaseId --limit=1 -q '.[] | .databaseId') | |
| fi | |
| if [ -z "$LAST_SUCCESSFUL_RUN_ID" ]; then | |
| echo "::error::No successful run found on the target branch for 'push' or 'workflow_dispatch' or 'schedule' events." |
| @@ -173,7 +173,8 @@ This action provides the following outputs: | |||
|
|
|||
| - Currently, code coverage profiles are uploaded as GitHub artifacts which automatically expire after 90 days. | |||
| In a repository which receives changes only infrequently, this might lead to issues when trying to compare | |||
| the code coverage of a pull request with the code coverage of the main branch (see fgrosse/go-coverage-report#5). | |||
| the code coverage of a pull request with the code coverage of the main branch (see fgrosse/go-coverage-report#5). | |||
| As a workaround, consider using `workflow_dispatch`. | |||
There was a problem hiding this comment.
Suggested change
| As a workaround, consider using `workflow_dispatch`. | |
| As a workaround, consider using `workflow_dispatch` or `schedule`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5